Only forward declare '_mm_pause' if it is used#1923
Merged
Conversation
ericniebler
approved these changes
Mar 11, 2026
Collaborator
|
/ok to test 7cd37f6 |
gamecentric
pushed a commit
to gamecentric/stdexec
that referenced
this pull request
Mar 29, 2026
Only forward declare '_mm_pause' if it is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forward declaration of
extern void _mm_pause()leads to a compilation failure on GCC on Windows. The error message says that the forward declaration conflicts with the declaration in<xmmintrin.h>because only the latter isextern "C".The function is not called on GCC because of a preprocessor conditional. Guard the forward declaration with the same conditional.