Skip to content

give up trying to make fns constexpr that deal with exception_ptr or shared_ptr #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 1 commit into from
Feb 23, 2026
Merged

give up trying to make fns constexpr that deal with exception_ptr or shared_ptr #1887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/stdexec/__detail/__parallel_scheduler_backend.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ namespace STDEXEC
public:
virtual constexpr ~receiver_proxy() = 0;

virtual constexpr void set_value() noexcept = 0;
virtual STDEXEC_CONSTEXPR_CXX23 void set_error(std::exception_ptr) noexcept = 0;
virtual constexpr void set_stopped() noexcept = 0;
virtual constexpr void set_value() noexcept = 0;
virtual void set_error(std::exception_ptr) noexcept = 0;
virtual constexpr void set_stopped() noexcept = 0;

/// Query the receiver for a property of type `_Query`.
template <class _Value, __class _Query>
Expand Down Expand Up @@ -186,7 +186,7 @@ namespace STDEXEC
return false;
}

STDEXEC_CONSTEXPR_CXX23 void set_error(std::exception_ptr eptr) noexcept final
void set_error(std::exception_ptr eptr) noexcept final
{
if constexpr (_Infallible)
{
Expand Down Expand Up @@ -345,7 +345,7 @@ namespace STDEXEC
__proxy.set_value();
}

STDEXEC_CONSTEXPR_CXX23 void set_error(std::exception_ptr __eptr) noexcept
void set_error(std::exception_ptr __eptr) noexcept
{
auto& __proxy = __rcvr_proxy_;
__delete_fn_(__opstate_storage_); // NB: destroys *this
Expand Down
26 changes: 11 additions & 15 deletions include/stdexec/__detail/__task_scheduler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ namespace STDEXEC
{}

[[nodiscard]]
STDEXEC_CONSTEXPR_CXX23 auto schedule() const noexcept -> __task::__sender;
auto schedule() const noexcept -> __task::__sender;

[[nodiscard]]
bool operator==(task_scheduler const & __rhs) const noexcept = default;
Expand Down Expand Up @@ -192,7 +192,7 @@ namespace STDEXEC
public:
using operation_state_concept = operation_state_t;

STDEXEC_CONSTEXPR_CXX23 explicit __any_opstate(__backend_ptr_t __backend, _Rcvr __rcvr)
explicit __any_opstate(__backend_ptr_t __backend, _Rcvr __rcvr)
: __rcvr_proxy_(std::move(__rcvr))
, __backend_(std::move(__backend))
{}
Expand Down Expand Up @@ -220,7 +220,7 @@ namespace STDEXEC
{
using sender_concept = sender_t;

STDEXEC_CONSTEXPR_CXX23 explicit __sender(task_scheduler __sch)
explicit __sender(task_scheduler __sch)
: __attrs_{std::move(__sch)}
{}

Expand Down Expand Up @@ -407,10 +407,7 @@ namespace STDEXEC
system_context_replaceability::bulk_item_receiver_proxy,
true>
{
STDEXEC_CONSTEXPR_CXX23 explicit __bulk_state(_Rcvr __rcvr,
size_t __shape,
_Fn __fn,
__backend_ptr_t __backend)
explicit __bulk_state(_Rcvr __rcvr, size_t __shape, _Fn __fn, __backend_ptr_t __backend)
: __bulk_state::__receiver_proxy_base(std::move(__rcvr))
, __fn_(std::move(__fn))
, __shape_(__shape)
Expand Down Expand Up @@ -475,11 +472,11 @@ namespace STDEXEC
{
using operation_state_concept = operation_state_t;

STDEXEC_CONSTEXPR_CXX23 explicit __bulk_opstate(_Sndr&& __sndr,
size_t __shape,
_Fn __fn,
_Rcvr __rcvr,
__backend_ptr_t __backend)
explicit __bulk_opstate(_Sndr&& __sndr,
size_t __shape,
_Fn __fn,
_Rcvr __rcvr,
__backend_ptr_t __backend)
: __state_{std::move(__rcvr), __shape, std::move(__fn), std::move(__backend)}
, __opstate1_(STDEXEC::connect(static_cast<_Sndr&&>(__sndr), __rcvr_t{&__state_}))
{}
Expand All @@ -506,7 +503,7 @@ namespace STDEXEC
{
using sender_concept = sender_t;

STDEXEC_CONSTEXPR_CXX23 explicit __bulk_sender(_Sndr __sndr, task_scheduler __sch)
explicit __bulk_sender(_Sndr __sndr, task_scheduler __sch)
: __sndr_(std::move(__sndr))
, __attrs_{std::move(__sch)}
{}
Expand Down Expand Up @@ -650,8 +647,7 @@ namespace STDEXEC
} // namespace __task

[[nodiscard]]
inline STDEXEC_CONSTEXPR_CXX23 auto task_scheduler::schedule() const noexcept //
-> __task::__sender
inline auto task_scheduler::schedule() const noexcept -> __task::__sender
{
return __task::__sender{*this};
}
Expand Down
Loading