Repository navigation
Add ALCHEMI Toolkit to the product enum - #852
Merged
Merged
Conversation
Signed-off-by: Moshe Abramovitch <moshea@nvidia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mosheabr
requested review from
jasonnvidia,
sayalinvidia and
siqinvidia
as code owners
November 9, 2026 21:47
siqinvidia
approved these changes
Nov 9, 2026
siqinvidia
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at 847b2f4. This adds only ALCHEMI Toolkit to the product.primary schema enum, matching the existing component name. Verified that the generator now derives that exact product deterministically (previously None), JSON Schema validation passes, and existing metadata failure/product-mapping regression tests all pass. DCO, Authors, Content Integrity and NVSkills CI gate pass. The metadata check fails only on benchmarks.json awaiting aggregation following #849; regeneration after this schema fix will produce the downstream generated files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ALCHEMI Toolkitto theproduct.primaryenum. The metadata regen has been failing on the newnvalchemi-toolkitskill (#851) because no matching product value exists. The value matches thenameincomponents.d/alchemi-toolkit.yml, so no registry change is needed.Generated files will update in the next metadata regeneration.
🤖 Generated with Claude Code