skip invoking toolkit.Install when NRI Plugin is enabled#1754
Open
skip invoking toolkit.Install when NRI Plugin is enabled#1754
Conversation
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Coverage Report for CI Build 24059267912Coverage increased (+0.003%) to 43.403%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the "nvidia-operator-validator pod stuck indefinitely in Terminating" issue observed in clusters that use
cri-o + crunProblem
The toolkit by default sources a list of the absolute paths of low-level runtime binaries from the containerd/crio runtime config TOML file. This list is then prepended to the
runtimes= ["runc", "crun"]list in the toolkit's config TOML file. Through this method, the toolkit binds thenvidia-container-runtimewrapper script to the correct low-level runtime binary. With the switch to the NRI Plugin mode, the toolkit no longer reads from the containerd/crio runtime config TOML file, so it does not have a way to inject the correct low-level runtime binary to thenvidia-container-runtimewrapper script. As a result, pods that were created with thenvidia-container-runtimebound to the low-level-runtime binary (sourced from the container runtime config TOML) before NRI Plugin enablement cannot be deleted afterwards as the wrapper-script just binds toruncinstead (taken from the default listruntimes = ["runc", "crun"]. This discrepancy innvidia-container-runtimebefore and after NRI Plugin enablement causes theKillContainerfunctions performed by the container runtime to fail leaving the pod stuck in Terminating permanentlySolution
Currently, the toolkit always clears the files in the toolkit root
/usr/local/nvidia/toolkiton every run and installs the toolkit artifacts. With NRI Plugin,nvidia-container-runtimeis no longer needed, so retain the toolkit installed files created from the toolkit deployment prior to the NRI Plugin enablement. This unblocks the termination of the pods created before NRI Plugin enablement, as thenvidia-container-runtimestill resolves to the desired low-level-runtime binary as initially configured.