Remove tracked .bak files that violate the project's own .gitignore - #16
Open
Anilreddy2309 wants to merge 1 commit into
Open
Anilreddy2309 wants to merge 1 commit into
Anilreddy2309 wants to merge 1 commit into
Conversation
nvflow/recipes/finance/datasets/finance_agent/eval.jsonl.bak (60KB) and public.csv.bak (56KB) were committed in the initial public release despite .gitignore explicitly listing *.bak / *.bak-* -- .gitignore doesn't retroactively untrack files already committed before the pattern was added. Confirmed via grep that no .py/.yaml/.md file references either filename, and `git log --follow` shows neither has been touched since the initial commit -- these are stale backup artifacts with no apparent purpose, not a fallback data source anything depends on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Anil Balireddy <anilbalireddi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvflow/recipes/finance/datasets/finance_agent/eval.jsonl.bak(60KB) andpublic.csv.bak(56KB) were committed in the initial public release despite.gitignoreexplicitly listing*.bak/*.bak-*(.gitignore:89-90)..gitignoredoesn't retroactively untrack files that were already committed before the pattern was added, so these two have been sitting in the repo regardless.Confirmed before removing:
grep -rn "eval.jsonl.bak\|public.csv.bak"across.py/.yaml/.mdfinds zero references — nothing reads these as a fallback/backup data sourcegit log --followshows neither file has been touched since543d93e(Initial public release) — genuinely stale artifacts, not active backupsTest plan
pytest tests/suite passes (339 passed, 3 pre-existing skips) — no test or code depended on either file🤖 Generated with Claude Code