Skip to content

chore: refine codeowners routing#365

Open
kristinapathak wants to merge 1 commit into
mainfrom
chore/fine-grained-codeowners
Open

chore: refine codeowners routing#365
kristinapathak wants to merge 1 commit into
mainfrom
chore/fine-grained-codeowners

Conversation

@kristinapathak

@kristinapathak kristinapathak commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Add back team-based CODEOWNERS routing for major NVCF ownership areas while retaining @NVIDIA/nvcf-dev as the fallback and @NVIDIA/nvcf-admin ownership of .github/CODEOWNERS.

Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)

  • Routes control-plane and invocation-plane service paths to @NVIDIA/nvcf-control-plane-dev, including former invocation, SIS, and Stargate ownership.
  • Routes compute-plane paths and NVCA-related charts/stack ownership to @NVIDIA/nvcf-compute-plane-dev.
  • Routes Cassandra, NATS, and OpenBao infrastructure paths to @NVIDIA/nvcf-infra-dev.
  • Routes GitHub workflows, ci, and tools paths to @NVIDIA/nvcf-ci-dev.
  • Routes docs/ to @NVIDIA/nvcf-docs-dev.
  • Some subgroup teams may be created after this file lands; the CODEOWNERS entries capture the intended routing.

For the Reviewer

Please review the .github/CODEOWNERS grouping and rule ordering.

For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)

Validation:

  • git diff --check
  • local CODEOWNERS path existence check

Is QA Needed? No, CODEOWNERS-only metadata change.

Issues

Closes #364

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Improved repository ownership and review routing across workflows, documentation, infrastructure, and service components.
    • Added clearer guidance for maintaining ownership rules and fallback coverage.
    • No end-user-facing functionality or behavior changes.

Signed-off-by: Kristina Pathak <kristina.m.pathak@gmail.com>
@kristinapathak
kristinapathak requested a review from a team as a code owner July 22, 2026 21:20
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b7a3fd0e-a6ad-4988-8632-db7f2d11c21a

📥 Commits

Reviewing files that changed from the base of the PR and between 97a4611 and 6e5de79.

📒 Files selected for processing (1)
  • .github/CODEOWNERS

📝 Walkthrough

Walkthrough

The CODEOWNERS file now documents rule precedence and fallback behavior, preserves existing owners, and adds explicit ownership routing for CI/tools, documentation, infrastructure, control-plane, and compute-plane paths.

Changes

CODEOWNERS routing

Layer / File(s) Summary
Ownership policy and fallbacks
.github/CODEOWNERS
Documents last-match precedence and fallback behavior while retaining repository and CODEOWNERS-file ownership.
Area-specific ownership routing
.github/CODEOWNERS
Routes CI/tools, documentation, infrastructure, control-plane, and compute-plane paths to their respective teams.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The Conventional Commits chore prefix matches this CODEOWNERS-only routing update and accurately describes the change.
Linked Issues check ✅ Passed The CODEOWNERS rules keep the fallback owner and admin ownership while routing control, compute, infra, CI/tools, and docs paths as requested.
Out of Scope Changes check ✅ Passed The diff is limited to .github/CODEOWNERS plus related ordering comments, which stays within the routing update scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fine-grained-codeowners

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fine-grained CODEOWNERS routing

2 participants