feat(self-managed): add function-autoscaler release#353
Draft
bright-poku wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bright-poku
force-pushed
the
feat/wire-function-autoscaler-self-managed
branch
from
July 22, 2026 16:16
7747ae4 to
25e9802
Compare
Add a function-autoscaler release to the self-managed stack's stage-03 observability helmfile, gated on a new functionAutoscaler toggle that is disabled by default. The release is ordered after state-metrics and depends on the stage-01 Cassandra and OpenBao migrations and a reachable VictoriaMetrics from the observability stack. Only the in-cluster endpoints (Cassandra contact points and VictoriaMetrics URL) are environment-specific; SECRETS_PATH and CONFIG come from the chart defaults. Signed-off-by: Bright Poku <bpoku@nvidia.com>
bright-poku
force-pushed
the
feat/wire-function-autoscaler-self-managed
branch
from
July 22, 2026 16:23
25e9802 to
f53986f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Wire the function-autoscaler workload into the self-managed stack's stage-03
observability helmfile, gated behind a new
functionAutoscalertoggle that isdisabled by default.
Additional Details
function-autoscalerrelease todeploy/stacks/self-managed/helmfile.d/03-observability.yaml.gotmpl,conditioned on
functionAutoscaler.enabledand ordered afterstate-metrics.functionAutoscalervalues block toenvironments/base.yaml(disabled by default; empty endpoints; chart-version placeholder).
servicetemplate.SECRETS_PATHandCONFIGcome from the chart defaults; only the in-cluster endpoints(Cassandra contact points and VictoriaMetrics URL) are environment-specific.
VictoriaMetrics from the observability stack.
Draft until the function-autoscaler chart is published:
chartVersionis a0.0.0placeholder that must be pinned to the publishedhelm-nvcf-function-autoscalerversion before this can merge.For the Reviewer
base.yamlvalues block and the03-observabilityrelease.condition: functionAutoscaler.enabled,which is
falsein base), so this is safe to land ahead of enabling any env.For QA
Validated with
helmfile listagainst the stage-03 helmfile:function-autoscalerrendersENABLED=false(not actioned).--state-values-set functionAutoscaler.enabled=true: rendersENABLED=true,namespace
nvcf, chartnvcf/helm-nvcf-function-autoscaler, ordered afterstate-metrics.Issues
Closes #352
Checklist