Skip to content

feat(self-managed): add function-autoscaler release#353

Draft
bright-poku wants to merge 1 commit into
mainfrom
feat/wire-function-autoscaler-self-managed
Draft

feat(self-managed): add function-autoscaler release#353
bright-poku wants to merge 1 commit into
mainfrom
feat/wire-function-autoscaler-self-managed

Conversation

@bright-poku

Copy link
Copy Markdown
Contributor

TL;DR

Wire the function-autoscaler workload into the self-managed stack's stage-03
observability helmfile, gated behind a new functionAutoscaler toggle that is
disabled by default.

Additional Details

  • Adds a function-autoscaler release to
    deploy/stacks/self-managed/helmfile.d/03-observability.yaml.gotmpl,
    conditioned on functionAutoscaler.enabled and ordered after state-metrics.
  • Adds the functionAutoscaler values block to environments/base.yaml
    (disabled by default; empty endpoints; chart-version placeholder).
  • The release inherits the shared service template. SECRETS_PATH and
    CONFIG come from the chart defaults; only the in-cluster endpoints
    (Cassandra contact points and VictoriaMetrics URL) are environment-specific.
  • Depends on the stage-01 Cassandra and OpenBao migrations and a reachable
    VictoriaMetrics from the observability stack.

Draft until the function-autoscaler chart is published: chartVersion is a
0.0.0 placeholder that must be pinned to the published
helm-nvcf-function-autoscaler version before this can merge.

For the Reviewer

  • Two files: the base.yaml values block and the 03-observability release.
  • Note the release is inert by default (condition: functionAutoscaler.enabled,
    which is false in base), so this is safe to land ahead of enabling any env.

For QA

Validated with helmfile list against the stage-03 helmfile:

  • Default (toggle off): function-autoscaler renders ENABLED=false (not actioned).
  • --state-values-set functionAutoscaler.enabled=true: renders ENABLED=true,
    namespace nvcf, chart nvcf/helm-nvcf-function-autoscaler, ordered after
    state-metrics.

Issues

Closes #352

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f66655d9-3481-4e15-b839-8946159b9308

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/wire-function-autoscaler-self-managed

Comment @coderabbitai help to get the list of available commands.

@bright-poku bright-poku changed the title feat(self-managed): wire function-autoscaler release into stage-03 feat(self-managed): wire function-autoscaler release into self-managed stack Jul 22, 2026
@bright-poku
bright-poku force-pushed the feat/wire-function-autoscaler-self-managed branch from 7747ae4 to 25e9802 Compare July 22, 2026 16:16
@bright-poku bright-poku changed the title feat(self-managed): wire function-autoscaler release into self-managed stack feat(self-managed): add function-autoscaler release Jul 22, 2026
Add a function-autoscaler release to the self-managed stack's stage-03
observability helmfile, gated on a new functionAutoscaler toggle that is
disabled by default.

The release is ordered after state-metrics and depends on the stage-01
Cassandra and OpenBao migrations and a reachable VictoriaMetrics from the
observability stack. Only the in-cluster endpoints (Cassandra contact
points and VictoriaMetrics URL) are environment-specific; SECRETS_PATH and
CONFIG come from the chart defaults.

Signed-off-by: Bright Poku <bpoku@nvidia.com>
@bright-poku
bright-poku force-pushed the feat/wire-function-autoscaler-self-managed branch from 25e9802 to f53986f Compare July 22, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add function-autoscaler release to the self-managed stack

1 participant