feat(self-managed): add opt-in nvcf-ui addon to the self-managed stack#350
Draft
vrv3814 wants to merge 6 commits into
Draft
feat(self-managed): add opt-in nvcf-ui addon to the self-managed stack#350vrv3814 wants to merge 6 commits into
vrv3814 wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The self-managed stack had no way to deploy the NVCF UI. Operators who want the
web UI had to wire the release, backend URLs, and health-monitor config by hand.
This adds a first-class, opt-in addon so the UI installs with the rest of the
control plane and its config tracks the stack's actual backend coordinates.
What changed
nvcf-uirelease (chartnvcf/helm-nvcf-ui1.0.2, namespacenvcf-ui), gated onaddons.nvcfUi.enabled, needingnvcf/invocation-service. Bump theingressgateway-routes chart from 1.13.4 to 1.15.0 to pick up the nvcf-uiroute support.
nvcfUivalues block only when the addon isenabled. Backend URLs (nvcf-api, nvct-api, sis) and the control-plane health
monitor component list are derived from the same
ingress.gatewayApi.routes.<x>.backendcoordinates gateway-routes uses, withdict defaults, so operator route overrides flow through. Health components for
optional services (ratelimiter, llm, vanity-gateway, nats, openbao, cassandra,
cert-manager, envoy-gateway) are included only when their feature is enabled.
The openbao-migrations image tag floors at 0.16.2 and honors a newer operator
override. Add the nvcf-ui HTTPRoute under
nvcfGatewayRoutes, enabled by thesame addon flag.
addons.nvcfUi.enabled: falsedefault,the
ingress...nvcfUiroute override stub, andnvcf-uito the openbaonamespace list.
Customer Release Notes
Self-managed NVCF can now deploy the NVCF web UI as an opt-in addon. Set
addons.nvcfUi.enabled: trueto install it.Plan Summary
When enabled: one new Helm release (
nvcf-uiin namespacenvcf-ui), oneopenbao-migrations job, and one nvcf-ui HTTPRoute. Disabled by default, so
existing installs see no change.
Usage
Enable in your environment values:
Testing
Rendered the helmfile with the addon disabled (no-op) and enabled to confirm the
values block, route, and release template correctly. QA: recommend a full
self-managed install with
addons.nvcfUi.enabled: trueto validate the UI andhealth monitor end to end.
Notes
Health-monitor component list and backend URLs are derived from the stack's
route backends rather than the chart defaults, so they stay correct under
operator route overrides.
References
<add a public NVIDIA/nvcf issue: Closes #NNN>
Related Pull Requests
None
Dependencies
Chart bumps only:
nvcf/nvcf-gateway-routes1.13.4 -> 1.15.0, newnvcf/helm-nvcf-ui1.0.2. No new third-party libraries.