Skip to content

ci: tolerate CRLF line endings in pr-issue-check #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
along-2017 wants to merge 1 commit into from
+4 −0
Closed

ci: tolerate CRLF line endings in pr-issue-check #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci/check-pr-issue.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ if repo.lower() != "nvidia/nvcf":
sys.exit(1)

body = os.environ.get("PR_BODY", "")
# GitHub stores PR bodies with CRLF line endings (web UI and bot edits), so
# normalize to LF before matching; the ## Issues heading regex expects a bare
# newline and would otherwise fail to find the section on a CRLF body.
body = body.replace("\r\n", "\n").replace("\r", "\n")
visible = re.sub(r"<!--.*?(?:-->|$)", "", body, flags=re.S)

section_match = re.search(
Expand Down
Loading