Skip to content

fix(openbao-migrations): sleep between health check retries #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesutoezdil wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(openbao-migrations): sleep between health check retries #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions migrations/openbao/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ while [ $retry_count -lt $MAX_RETRIES ]; do
else
log_info "OpenBao service not responsive. Retrying in $RETRY_DELAY seconds..."
retry_count=$((retry_count + 1))
sleep "$RETRY_DELAY"
Comment thread
mesutoezdil marked this conversation as resolved.
fi
done

Expand Down Expand Up @@ -93,7 +94,7 @@ initialize_mount_lists
# exits non-zero whenever any required task fails. The previous behavior
# (warn-and-continue, exit 0 regardless) let misconfigured deployments
# green the Helm hook Job while leaving OpenBao in a half-configured
# state — surfacing later as a downstream service-cert outage instead of
# state, surfacing later as a downstream service-cert outage instead of
# a blocked deployment.
#
# Addons enter the accumulator only when they're explicitly enabled
Expand Down Expand Up @@ -184,7 +185,7 @@ if [ "${#FAILED_MIGRATIONS[@]}" -gt 0 ]; then
log_error " - $m"
done
if [ "${MIGRATIONS_ALLOW_FAILURES:-false}" = "true" ]; then
log_warn "MIGRATIONS_ALLOW_FAILURES=true; exiting 0 despite ${#FAILED_MIGRATIONS[@]} failure(s) — investigate before next deploy"
log_warn "MIGRATIONS_ALLOW_FAILURES=true; exiting 0 despite ${#FAILED_MIGRATIONS[@]} failure(s); investigate before next deploy"
else
log_error "Exiting non-zero. Set MIGRATIONS_ALLOW_FAILURES=true only as an emergency rollback override"
exit 1
Expand Down