fix(distributed): correct AIMNet2 stress reduction - #154
Open
atulcthakur wants to merge 2 commits into
Open
Conversation
Signed-off-by: atulcthakur <atthakur@nvidia.com>
Contributor
Greptile SummaryAdds global AIMNet2 stress reduction and enables strain-derived stress for compiled domain decomposition.
Important Files Changed
Reviews (2): Last reviewed commit: "test(distributed): cover compiled AIMNet..." | Re-trigger Greptile |
Signed-off-by: atulcthakur <atthakur@nvidia.com>
Collaborator
Author
|
/ok to test ca8bd9d |
Collaborator
Author
|
/ok to test ca8bd9d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALCHEMI Toolkit Pull Request
Description
AIMNet2 produced only rank-local stress contributions under eager domain decomposition, and compiled DD did not calculate stress.
This change:
auto_fix.Energy and force behavior is unchanged.
Type of Change
Related Issues
Changes Made
nvalchemi/models/aimnet2.pytest/distributed/model/test_distributed_models.pytest/distributed/validate/test_validate_cuda.pyTesting
make pytest)make lint)Checklist
Additional Notes
Tip
This repository uses Greptile, an AI code review service, to help conduct
pull request reviews. We encourage contributors to read and consider suggestions
made by Greptile, but note that human maintainers will provide the necessary
reviews for merging: Greptile's comments are not a qualitative judgement
of your code, nor is it an indication that the PR will be accepted/rejected.
We encourage the use of emoji reactions to Greptile comments, depending on
their usefulness and accuracy.