Skip to content

Bug fix: profiler kernelch event type field #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CavalryXD wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug fix: profiler kernelch event type field #1973

CavalryXD wants to merge 1 commit into from
+1 −1

Conversation

@CavalryXD
Copy link

@CavalryXD CavalryXD commented Jan 7, 2026

Description

I run NCCL Profiler to check the kernelCh event in single node with 8 * A100 GPUs. And I just clone the master branch code from NCCL. And I got the unexpected results where most of kernelCh events have stopTs 0 and StopGpuClk 0.
I use the recommended compilation, just make.
The launch script is follows:

export NCCL_PROFILER_PLUGIN=example
export NCCL_PROFILE_EVENT_MASK=127
export LD_LIBRARY_PATH=/workspace/nccl/ext-profiler/example:$LD_LIBRARY_PATH
export NCCL_DEBUG=INFO
export LD_LIBRARY_PATH=/usr/local/mpi/lib:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=/usr/local/ucx/lib:$LD_LIBRARY_PATH
export NCCL_PROFILE_DUMP_FILE=/workspace/profiler-test/
all_reduce_perf -b 128M -e 128M -g 8

Then the event result is(Show only a portion to save space.)

{"name": "Group API", "cat": "GROUP_API", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 59338.332001, "args": {"groupApiId": 0, "groupDepth": 2}},
{"name": "AllReduce", "cat": "COLL_API", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000, "args": {"count": 33554432, "datatype": "ncclFloat32", "root": 0, "GraphCaptured": 0, "Stream": "0x5653e4837400"}},
{"name": "AllReduce", "cat": "COLL", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 337378.026001, "args": {"SeqNum": 0, "CommHash": 17093776592125785438, "Rank": 0, "Count": 33554432, "Datatype": "ncclFloat32", "Algorithm": "RING", "Protocol": "SIMPLE", "nChannels": 24}},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339964.869995, "args": {"Channel": 0, "StartGpuClk": 1767766829233827840, "StopGpuClk": 1767766829235279872}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 339967.748016},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.009003, "args": {"Channel": 1, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.083008, "args": {"Channel": 2, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.249023, "args": {"Channel": 3, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.387024, "args": {"Channel": 4, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.512024, "args": {"Channel": 5, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.838013, "args": {"Channel": 6, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339965.979004, "args": {"Channel": 7, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.042999, "args": {"Channel": 8, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.109009, "args": {"Channel": 9, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.171021, "args": {"Channel": 10, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.299011, "args": {"Channel": 11, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.423004, "args": {"Channel": 12, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.485016, "args": {"Channel": 13, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.581024, "args": {"Channel": 14, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.723022, "args": {"Channel": 15, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.785004, "args": {"Channel": 16, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.843018, "args": {"Channel": 17, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.903015, "args": {"Channel": 18, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339966.964996, "args": {"Channel": 19, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339967.025024, "args": {"Channel": 20, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339967.085022, "args": {"Channel": 21, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339967.145020, "args": {"Channel": 22, "StartGpuClk": 1767766829233827840, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75087, "tid": 1, "ts": 339967.206024, "args": {"Channel": 23, "StartGpuClk": 1767766829233828864, "StopGpuClk": 0}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 0.000000},
{"name": "AllReduce", "cat": "COLL", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 337388.553009},
{"name": "AllReduce", "cat": "COLL_API", "ph": "e", "id": 0, "pid": 75087, "tid": 1, "ts": 59339.919006},
{"name": "AllReduce", "cat": "COLL_API", "ph": "b", "id": 1, "pid": 75087, "tid": 1, "ts": 0.000000, "args": {"count": 33554432, "datatype": "ncclFloat32", "root": 0, "GraphCaptured": 0, "Stream": "0x5653e52cc7d0"}}

For this problem, with nccl-2.27.3 version ext-profiler plugin code, I can get the right result.
I found the root cause is the wrong type in ext-profiler/example/event.h:struct kernelCh

struct kernelCh {
  uint8_t type;
  uint8_t channelId;
  struct taskEventBase* parent;
  double startTs;
  double stopTs;
  uint64_t startGpuClk;
  uint64_t stopGpuClk;
};

the type field is declared as uint8_t. However, the updateEvent function in plugin.cc assumes every event type is uint64_t. Here is the code snippet.

void updateEvent(void* handle) {
  uint64_t type = *(uint64_t *)handle;
  if (type == ncclProfileGroupApi) {
    struct groupApi* event = (struct groupApi*) handle;
    if (__atomic_sub_fetch(&event->refCount, 1, __ATOMIC_RELAXED) == 0) {
      event->stopTs = gettime() - startTime;
      __atomic_fetch_add(&event->ctx->groupApiPoolBase, 1, __ATOMIC_RELAXED);
    }

Related Issues

Changes & Impact

Modify the declaration of type in struct kernelCh from uint8_t to uint_64_t.

Performance Impact

I modify the kernelCh type declaration and get the right result.

{"name": "Group API", "cat": "GROUP_API", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 665250.903015, "args": {"groupApiId": 24, "groupDepth": 2}},
{"name": "AllReduce", "cat": "COLL_API", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 0.000000, "args": {"count": 33554432, "datatype": "ncclFloat32", "root": 0, "GraphCaptured": 0, "Stream": "0x55e9cc9f00a0"}},
{"name": "AllReduce", "cat": "COLL", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 665340.231995, "args": {"SeqNum": 35, "CommHash": 5864535264783067618, "Rank": 0, "Count": 33554432, "Datatype": "ncclFloat32", "Algorithm": "RING", "Protocol": "SIMPLE", "nChannels": 24}},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.421997, "args": {"Channel": 0, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946195968}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668952.882019},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.559021, "args": {"Channel": 1, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946166272}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668922.959015},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.619019, "args": {"Channel": 2, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946094592}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668852.377014},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.677002, "args": {"Channel": 3, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946094592}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668852.464996},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667678.953003, "args": {"Channel": 4, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946195968}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668952.145996},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.095001, "args": {"Channel": 5, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946093568}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668852.579010},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.187012, "args": {"Channel": 6, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946196992}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668953.483002},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.282013, "args": {"Channel": 7, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946190848}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668947.024994},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.339996, "args": {"Channel": 8, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946193920}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668950.876007},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.494019, "args": {"Channel": 9, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946113024}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668869.444000},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.555023, "args": {"Channel": 10, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946088448}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668845.723999},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.612000, "args": {"Channel": 11, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946191872}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668948.355011},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.669006, "args": {"Channel": 12, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946089472}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668846.352020},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.731995, "args": {"Channel": 13, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946191872}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668948.453003},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.794006, "args": {"Channel": 14, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946190848}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668947.277008},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.852997, "args": {"Channel": 15, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946192896}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668949.598022},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.912994, "args": {"Channel": 16, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946121216}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668878.059021},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667679.971008, "args": {"Channel": 17, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946113024}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668869.851013},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.029999, "args": {"Channel": 18, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946190848}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668947.460999},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.089996, "args": {"Channel": 19, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946102784}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668859.369995},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.153015, "args": {"Channel": 20, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946162176}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668919.180023},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.212006, "args": {"Channel": 21, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946191872}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668948.628998},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.270020, "args": {"Channel": 22, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946191872}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668948.707001},
{"name": "KernelCh", "cat": "GPU", "ph": "b", "id": 0, "pid": 75701, "tid": 1, "ts": 667680.333008, "args": {"Channel": 23, "StartGpuClk": 1767766887944922112, "StopGpuClk": 1767766887946088448}},
{"name": "KernelCh", "cat": "GPU", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668845.544006},
{"name": "AllReduce", "cat": "COLL", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668953.520996},
{"name": "AllReduce", "cat": "COLL_API", "ph": "e", "id": 0, "pid": 75701, "tid": 1, "ts": 668953.718018},
{"name": "AllReduce", "cat": "COLL_API", "ph": "b", "id": 1, "pid": 75701, "tid": 1, "ts": 0.000000, "args": {"count": 33554432, "datatype": "ncclFloat32", "root": 0, "GraphCaptured": 0, "Stream": "0x55e9cd485760"}}

chenhengqi
chenhengqi approved these changes Jan 8, 2026
View reviewed changes
Copy link

@chenhengqi chenhengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but per the CONTRIBUTING.md, you need a sob in your commit message.

@CavalryXD CavalryXD force-pushed the fix-profiler-kernelch-field-type branch from 193309c to f6cc48a Compare January 8, 2026 02:51
@CavalryXD
fix profiler kernelch event type field
1ad33f4 
Signed-off-by: CavalryXD <m18091747580_1@163.com>
@CavalryXD CavalryXD force-pushed the fix-profiler-kernelch-field-type branch from f6cc48a to 1ad33f4 Compare January 8, 2026 03:00
@CavalryXD
Copy link
Author

CavalryXD commented Jan 8, 2026

Looks good, but per the CONTRIBUTING.md, you need a sob in your commit message.

Thanks for your reply, I have added the sob in commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chenhengqi chenhengqi chenhengqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CavalryXD @chenhengqi