fix: Invalid nullptr initialization for CUmemGenericAllocationHandle when compiling with Clang #1971
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Clang build problem with wrong type
jushg
changed the title
jushg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CUmemGenericAllocationHandle is defined as unsigned long long (not a pointer type). Initializing it with nullptr is invalid in C++ since nullptr cannot be implicitly converted to an integer type. This causes a compilation error with Clang:
Why this was not caught with Makefile build?
NVIDIA's Makefile build uses NVCC with GCC as the host compiler, which historically allows implicit nullptr to integer conversions as a GCC extension (with only a warning). Clang rejects this as a hard error per the C++ standard.
Related Issues
Changes & Impact
This was the original code in v2.28, only change in v2.29 to nullptr, so this PR just revert that.
Performance Impact