Repository navigation
fix(diskgraph): run bench_runtime_batch_iterator with resolution-mode seeds - #330
Conversation
… seeds The benchmark still ingested its seed table with the removed FK-edge seed mode, so ingest failed with "fkey ENTITY1 references missing table users" before any timing ran. Build the seed fixture the way test_runtime_batch_iterator_e2e.py does: an entity_node_id column, no fkeys, and entity_node_type="users" on the iterator. The timed loop is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
Change map
Failure: the script raised Merge revalidation: merged current |
|
Additional validation and CPU measurements against current The unmodified main script still fails during seed ingestion with
Method:
For a single-pass reproduction with the matching native build, run the PR script from python python/tests/bench_runtime_batch_iterator.py --n-users 10000 --orders-per-user 8 --n-seeds 10000 --batch-size 128 --n-iter 100000
python python/tests/bench_runtime_batch_iterator.py --n-users 200000 --orders-per-user 8 --n-seeds 200000 --batch-size 128 --n-iter 100000
python python/tests/bench_runtime_batch_iterator.py --n-users 200000 --orders-per-user 8 --n-seeds 200000 --batch-size 512 --n-iter 100000Fused dispatch had 1.33–1.45× higher throughput on this narrow synthetic fixture. The fixture has few feature columns; these local warmed-cache results do not establish the best dispatch mode for wide features, other graph shapes, cold storage, GPU training, or production workloads. No benchmark source changes were needed beyond this PR. Individual timed runs (milliseconds, chronological within each mode)
|
Summary
diskgraph-pybind/python/tests/bench_runtime_batch_iterator.pyfails onmainbefore timing anything:The seed table still used the removed FK-edge seed mode (
external_parentfkey). This builds the seed fixture the same way astest_runtime_batch_iterator_e2e.py: anentity_node_idcolumn,fkeys: [], andentity_node_type="users"on the iterator. The timed loop is unchanged.Found while benchmarking #133.
Change map
File-by-file rationale
Testing Done
Against a
uv pip installofpackages/diskgraphatmain(32afaed8), Linux:--n-users 200000 --orders-per-user 8 --n-seeds 200000 --batch-size 512 --n-iter 300: completes for both fused and non-fused dispatch.shuffle=False, all 2,500task.seed_node_idsequalENTITY1(i % n_users) for fused and non-fused iteration.Checklist
🤖 Generated with Claude Code