Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Change mapExisting behavior: temporal requests assume seconds even on other index clocks, which can return incorrect rows or lengths. The smallest change is to reject those clocks before either executor runs.
Verification: fresh release build; 356 temporal tests and 49 RDL golden checks passed; Ruff and diff whitespace checks passed. All 18 new refusal cases fail against the previous build. Stopping condition: the seconds-only guard. Support for other index clocks remains tracked in #220. |
|
/ok to test c5ac802 |
Vedaant-J
left a comment
There was a problem hiding this comment.
okay because it only affects rdl
|
/ok to test c5ac802 |
1 similar comment
|
/ok to test c5ac802 |
Summary
query_temporalandquery_temporal_lengthsnow raiseDiskgraphConfigErrorfor non-seconds indexes instead of returning unreliable results. Seconds indexes retain existing behavior.Follow-up clock support is tracked in #220. Replaces the deferred #165.
Change map
File-by-file change map.
Testing Done
Fresh release native build; 356 temporal tests and 49 RDL golden checks passed. All 18 new refusal cases fail against the previous build. Ruff and
git diff --checkpass.