Skip to content

Reject non-second indexes in temporal queries - #221

Open
bberger62 wants to merge 1 commit into
mainfrom
fix/temporal-seconds-only
Open

bberger62 wants to merge 1 commit into
mainfrom
fix/temporal-seconds-only

Conversation

@bberger62

@bberger62 bberger62 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

query_temporal and query_temporal_lengths now raise DiskgraphConfigError for non-seconds indexes instead of returning unreliable results. Seconds indexes retain existing behavior.

Follow-up clock support is tracked in #220. Replaces the deferred #165.

Change map

File-by-file change map.

Testing Done

Fresh release native build; 356 temporal tests and 49 RDL golden checks passed. All 18 new refusal cases fail against the previous build. Ruff and git diff --check pass.

@copy-pr-bot

copy-pr-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bberger62
bberger62 temporarily deployed to gha-kumo-workflow-tests November 5, 2026 14:24 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Both execute_lengths and execute now reject indexes whose timestamp unit is not seconds before validating roots or parsing the plan. A parameterized test checks that both methods raise DiskgraphConfigError for the listed non-seconds units.

Merge Risk: Moderate · up to c5ac8

Update the PR change map so the required validation passes before merging.

Pre-merge checks: Passed 2 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Change Map Design Review Inconclusive The required PR conversation comment beginning with <!-- kumo-pr-change-map --> is not available in the supplied review context, and the marker is absent from the checked-out repository. The diff co… Provide the complete PR conversation comment beginning with <!-- kumo-pr-change-map -->, including its Change map and design evidence. Then assess each listed change against the observed failure, existing behavior, smallest sufficient imp…
Passed Passed checks: 2 passed

Check name Status Explanation
Pr Size Passed The pull request changes 2 files. The limit is 40 files, so the size check passes.
Public Resource Access Passed The pull request adds no external URL, repository location, or package source location. The new paths point to local temporary test fixtures and local index metadata, which are excluded by the check.
Full details: Change Map Design Review

Explanation

The required PR conversation comment beginning with &lt;!-- kumo-pr-change-map --&gt; is not available in the supplied review context, and the marker is absent from the checked-out repository. The diff confirms two changed files: a shared seconds-unit guard in both temporal query entry points and parameterized refusal tests. Without the Change map prose, I cannot assess whether each proposed change is necessary, at the correct abstraction layer, preserves behavior, or includes the required stopping condition and verification rationale.

Resolution

Provide the complete PR conversation comment beginning with &lt;!-- kumo-pr-change-map --&gt;, including its Change map and design evidence. Then assess each listed change against the observed failure, existing behavior, smallest sufficient implementation, verification, and stopping condition.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6aafd69 and c5ac802.

Files selected for processing: 2

  • packages/diskgraph/diskgraph-pybind/python/tests/test_temporal_query_shapes.py
  • packages/diskgraph/diskgraph-pybind/src/temporal_query.rs

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@bberger62

bberger62 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Change map

Existing behavior: temporal requests assume seconds even on other index clocks, which can return incorrect rows or lengths. The smallest change is to reject those clocks before either executor runs.

File Function / scope What changed Why
packages/diskgraph/diskgraph-pybind/src/temporal_query.rs require_seconds_index, execute, execute_lengths Check index metadata once per call and return the existing configuration error unless the clock is seconds. Refuse unsupported clocks before producing results.
packages/diskgraph/diskgraph-pybind/python/tests/test_temporal_query_shapes.py test_temporal_queries_require_seconds_index Exercise both APIs for all nine non-seconds metadata units, using empty plans. Verify that neither entry point bypasses the refusal.

Verification: fresh release build; 356 temporal tests and 49 RDL golden checks passed; Ruff and diff whitespace checks passed. All 18 new refusal cases fail against the previous build.

Stopping condition: the seconds-only guard. Support for other index clocks remains tracked in #220.

@bberger62

bberger62 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

/ok to test c5ac802

@bberger62
bberger62 requested a review from Vedaant-J November 5, 2026 15:19

@Vedaant-J Vedaant-J left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay because it only affects rdl

@bberger62

Copy link
Copy Markdown
Contributor Author

/ok to test c5ac802

1 similar comment
@bberger62

Copy link
Copy Markdown
Contributor Author

/ok to test c5ac802

This branch was previously deployed

1 inactive deployment
gha-kumo-workflow-tests — c5ac8020 Deployed Nov 5, 2026 by bberger62 via import #1563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants