Skip to content

Keep pruning setup-uv caches - #157

Merged
aaron-kumo merged 1 commit into
mainfrom
setup-uv-prune-cache
Nov 4, 2026
Merged

aaron-kumo merged 1 commit into
mainfrom
setup-uv-prune-cache

Conversation

@aaron-kumo

@aaron-kumo aaron-kumo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

What

Set prune-cache: true on every setup-uv step that caches: the shared setup action and 31 workflow steps.

Why

setup-uv v9 changed the prune-cache default to false. Once the v10 bump (#183) lands, uv cache entries would hold every downloaded wheel, including the 200–600 MB CUDA wheels, instead of only wheels built from source. The repository's Actions cache is already at ~10.4 GB, 5.7 GB of it Rust caches, which those entries would evict.

prune-cache: true is already the default on the pinned v8.1.0, so nothing changes until the bump merges, and the two can merge in either order.

Change map and validation

@aaron-kumo

aaron-kumo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Change map

File Function / scope What changed Why
.github/actions/setup/action.yml "Set up Python" setup-uv step Add prune-cache: true. Keep the shared setup action's uv cache entries limited to source-built wheels after setup-uv v9 stopped pruning by default.
.github/workflows/_diskgraph-wheel.yml, .github/workflows/agent-skills.yml, .github/workflows/install.yml, .github/workflows/kumo-api-hotfix-release.yml, .github/workflows/kumo-api-lint.yml, .github/workflows/kumo-api-release.yml, .github/workflows/kumo-api-testing.yml, .github/workflows/kumo-sdk-lint.yml, .github/workflows/kumo-sdk-test-integration.yml, .github/workflows/kumo-sdk-test-unit.yml, .github/workflows/linting.yml, .github/workflows/oss-readiness.yml, .github/workflows/testing.yml, .github/workflows/testing_databricks.yml, .github/workflows/testing_gcs.yml, .github/workflows/ui-client-code-generate.yml setup-uv steps on GitHub-hosted runners with the default enable-cache: auto Add prune-cache: true. Same, for the 31 steps that call setup-uv directly and save caches.

Requested change: keep today's pruning before merging Dependabot's setup-uv v10 bump (#25, #27). Today the 32 setup-uv cache entries (keys contain -pruned-) total 0.16 GB of a 10.42 GB repository cache; Rust caches take 5.7 GB.

Smallest change: set the old default explicitly where caching happens. Steps with enable-cache: false, and the self-hosted momentic-ui-tests.yml job (where auto disables caching), are unchanged.

Verification:

  • actionlint on the changed workflows: no findings on changed lines (existing shellcheck notes only).
  • yamllint -c .yamllint.yml on the changed files: passed (existing comment-spacing warnings only).
  • node .github/scripts/workflow-security.cjs . --baseline .github/workflow-security-baseline.json: passed.

Stopping condition: every caching setup-uv step sets prune-cache: true. Caching pre-built wheels to cut PyPI downloads, the setup action's stated goal for its cache, is a separate cache-budget decision.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The shared setup action and GitHub Actions workflows now set prune-cache: true for uv setup.

Merge Risk: Minimal · up to 6b504

The cache-pruning changes are supported by the pinned action version and introduce no established merge-blocking risk.

Pre-merge checks: Passed 2 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Change Map Design Review Inconclusive The required marked PR conversation comment is unavailable. The checkout contains only the marker in the template and validation code, not the author’s comment body. The diff does show a focused chang… Provide the full PR conversation comment beginning with <!-- kumo-pr-change-map -->, or enable retrieval of the linked PR conversation, so the design rationale and verification claims can be assessed directly.
Passed Passed checks: 2 passed
Check name Status Explanation
Pr Size Passed The pull request changes 17 files. The limit is 40 files, so the check passes.
Public Resource Access Passed The pull request adds only prune-cache: true inputs to existing setup-uv configurations. The diff adds or modifies no URL, repository location, or package source location. The public resource acce…
Full details: Public Resource Access

Explanation

The pull request adds only prune-cache: true inputs to existing setup-uv configurations. The diff adds or modifies no URL, repository location, or package source location. The public resource access check is therefore not applicable.

Full details: Change Map Design Review

Explanation

The required marked PR conversation comment is unavailable. The checkout contains only the marker in the template and validation code, not the author’s comment body. The diff does show a focused change: one shared cached setup action and 31 cached workflow steps add prune-cache: true, while explicit enable-cache: false steps remain unchanged. However, this check requires reviewing the same comment for the observed failure or release requirement, existing behavior, smallest sufficient change, focused verification, and stopping condition. The supplied summary does not provide that full comment.

Resolution

Provide the full PR conversation comment beginning with &lt;!-- kumo-pr-change-map --&gt;, or enable retrieval of the linked PR conversation, so the design rationale and verification claims can be assessed directly.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between eb5b616 and 6b50452.

Files selected for processing: 3
  • .github/workflows/agent-skills.yml
  • .github/workflows/kumo-api-lint.yml
  • .github/workflows/kumo-sdk-lint.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@aaron-kumo
aaron-kumo force-pushed the setup-uv-prune-cache branch from 72c472f to 990c10b Compare November 3, 2026 17:39
@aaron-kumo
aaron-kumo temporarily deployed to gha-kumo-workflow-tests November 3, 2026 17:39 — with GitHub Actions Inactive
@aaron-kumo
aaron-kumo force-pushed the setup-uv-prune-cache branch from 990c10b to eb5b616 Compare November 3, 2026 17:45
@aaron-kumo
aaron-kumo temporarily deployed to gha-kumo-workflow-tests November 3, 2026 17:45 — with GitHub Actions Inactive
setup-uv v9 changed the prune-cache default to false, so the
v10 bump (#25, #27) would start caching every downloaded wheel,
including the 200-600 MB CUDA wheels. The repository's Actions
cache is already at its ~10 GB limit with 5.7 GB of Rust caches,
which unpruned uv entries would evict.

Set prune-cache: true in the shared setup action and on every
setup-uv step that caches (GitHub-hosted jobs using the default
enable-cache: auto). It is already the default on v8.1.0, so
nothing changes until the bump lands.
@aaron-kumo
aaron-kumo force-pushed the setup-uv-prune-cache branch from eb5b616 to 6b50452 Compare November 3, 2026 21:00
@aaron-kumo
aaron-kumo temporarily deployed to gha-kumo-workflow-tests November 3, 2026 21:00 — with GitHub Actions Inactive
@aaron-kumo
aaron-kumo merged commit 90f8e5d into main Nov 4, 2026
134 of 139 checks passed
@aaron-kumo
aaron-kumo deleted the setup-uv-prune-cache branch November 4, 2026 21:07

This branch was previously deployed

1 inactive deployment
gha-kumo-workflow-tests — 6b504526 Deployed Nov 3, 2026 by aaron-kumo via import #1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants