feat: probe all supported mem and graphics frequencies#135
Open
rootfs wants to merge 1 commit into
Open
Conversation
Signed-off-by: Huamin Chen <hchen@redhat.com>
rajatchopra
requested changes
May 4, 2026
Contributor
rajatchopra
left a comment
rajatchopra
left a comment
There was a problem hiding this comment.
Changing the return type of existing API would mean a breaking change. Cannot do so unless we introduce a version on the API with a backward compatible translator.
Although the existing API has a misleading name, we may have to live with the confusing option of creating another API (with another name) that does the right thing. e.g. DeviceGetAllSupportedMemoryClocks()
Collaborator
|
Actually, for this one, I would call it a bug and fix it. Just returning a single uint32 is meaningless for the purpose of the original C API, and was implemented incorrectly when reflected into the go API. It should always have been returning a list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #134
There is a hack in this fix, the generated api is manually modified, since I don't know how it is generated in the first place.