Skip to content

[REVIEW] Update Dockerfile for setup#27

Open
Nanthini10 wants to merge 3 commits into
NVIDIA:masterfrom
Nanthini10:update-dockerfile
Open

[REVIEW] Update Dockerfile for setup#27
Nanthini10 wants to merge 3 commits into
NVIDIA:masterfrom
Nanthini10:update-dockerfile

Conversation

@Nanthini10

Copy link
Copy Markdown

The previous version of the file used older version of RAPIDS and didn't build properly for me.

Changing it to use RAPIDS image instead of nvidia/cuda image as most of these packages come pre-installed including xgboost and light-gbm.

@RAMitchell RAMitchell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is that we might want the latest dmlc xgb and not the rapids version.

@Nanthini10

Copy link
Copy Markdown
Author

That's a good point, I can undo the xgboost install step. Would this require installing from source, or the latest stable version (using pip) is good enough?

@RAMitchell

Copy link
Copy Markdown
Collaborator

I think it should be source.

@Nanthini10

Copy link
Copy Markdown
Author

@RAMitchell I've updated the dockerfile but the xgboost install isn't working with the following error:

CMake Error at plugin/CMakeLists.txt:8 (message):
  Could not locate RMM library

I can run the same command within the container, but the Dockerfile for some reason fails. Do you know what could be the reason for this?

@RAMitchell

Copy link
Copy Markdown
Collaborator

I don't I'm afraid. Maybe @hcho3 has an idea?

@hcho3

hcho3 commented Aug 12, 2021

Copy link
Copy Markdown

RMM_ROOT=/opt/conda should be revised to point to the correct location of RMM library in the Conda environment.

@Nanthini10

Copy link
Copy Markdown
Author

@hcho3 is it /rapids/rmm or elsewhere?

However, this worked when I ran it inside rapidsai/rapidsai-dev:21.06-cuda11.0-devel-ubuntu18.04-py3.8

git config --global http.sslVerify false && \
    git clone --recursive https://github.com/dmlc/xgboost /opt/xgboost && \
    cd /opt/xgboost && \
    mkdir build && \
    cd build && \
    RMM_ROOT=/opt/conda cmake .. \
        -DUSE_CUDA=ON \
        -DUSE_NCCL=ON \
        -DPLUGIN_RMM=ON && \
    make -j4 && \
    cd ../python-package && \
    pip uninstall -y xgboost && \
    python setup.py install

@hcho3

hcho3 commented Aug 12, 2021

Copy link
Copy Markdown

Can you run echo $CONDA_PREFIX inside the container? That's where RMM is installed.

@Nanthini10

Copy link
Copy Markdown
Author

Thanks! That helped /opt/conda/envs/rapids

@Nanthini10 Nanthini10 requested a review from RAMitchell August 13, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants