Clarify global conditioning input semantics - #421
Merged
aidanfnv merged 1 commit intoAug 6, 2026
Merged
Conversation
Signed-off-by: Aidan Foster <aidanf@nvidia.com>
Contributor
Greptile SummaryThe PR separates input scope from consumption cadence and consistently renames the runtime API around global conditioning.
Confidence Score: 5/5The PR appears safe to merge, with the renamed runtime surfaces, tests, and documentation remaining internally consistent. No concrete changed-code failure remains: repository callers were migrated to the renamed API, reset already accepts an optional inference input, and cadence-independent compatibility is intentional and currently covered by tests. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
App[Application or runner] -->|global_conditioning| Session[Inference session state]
Source[User input source] --> Canonical[Canonical inputs]
Canonical --> Mapping[Input mapping]
Mapping -->|step payload| Step[InferenceSession.step]
Session --> Step
Step --> Result[StepResult]
Meta[frequency_consumed: once or per_step] -. adapter query hint .-> Session
Reviews (1): Last reviewed commit: "Clarify global conditioning input semant..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some very confusing overlap between input scope and frequency.
Instead of various lifecycles describing both attributes, inputs will now be "once" or "per_step", and for global conditioning or a step.
Also corrects incorrectly used "semantic type" terminology to "input modality".