Skip to content

Clarify global conditioning input semantics - #421

Merged
aidanfnv merged 1 commit into
dev/jarcher/inference-runtime-apifrom
dev/aidanf/T3-global-conditioning-frequency
Aug 6, 2026
Merged

Clarify global conditioning input semantics#421
aidanfnv merged 1 commit into
dev/jarcher/inference-runtime-apifrom
dev/aidanf/T3-global-conditioning-frequency

Conversation

@aidanfnv

@aidanfnv aidanfnv commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Removes some very confusing overlap between input scope and frequency.
Instead of various lifecycles describing both attributes, inputs will now be "once" or "per_step", and for global conditioning or a step.
Also corrects incorrectly used "semantic type" terminology to "input modality".

Signed-off-by: Aidan Foster <aidanf@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR separates input scope from consumption cadence and consistently renames the runtime API around global conditioning.

  • Renames the global input phase, schema fields, and mapping methods to use global_conditioning.
  • Replaces lifecycle and update-policy metadata with the independent frequency_consumed hint.
  • Clarifies that global conditioning establishes session state while StepRequest and StepResult remain per-step runtime messages.
  • Updates runtime tests and design documentation to match the revised semantics.

Confidence Score: 5/5

The PR appears safe to merge, with the renamed runtime surfaces, tests, and documentation remaining internally consistent.

No concrete changed-code failure remains: repository callers were migrated to the renamed API, reset already accepts an optional inference input, and cadence-independent compatibility is intentional and currently covered by tests.

Important Files Changed

Filename Overview
flashdreams/flashdreams/runtime/inputs.py Renames the global input phase and schema API, simplifies global-conditioning payload helpers, and introduces consumption-frequency metadata.
flashdreams/flashdreams/runtime/mapping.py Aligns mapping protocols and schemas with global-conditioning terminology while making cadence independent of compatibility matching.
flashdreams/flashdreams/runtime/init.py Removes the obsolete session-start-only update-policy export.
flashdreams/flashdreams/runtime/interfaces.py Clarifies the model schema and per-step request protocol documentation without changing signatures.
flashdreams/flashdreams/runtime/types.py Clarifies that step requests and results are runtime messages rather than schema declarations.
flashdreams/tests/test_runtime_input_mapping.py Updates compatibility coverage for the renamed phases and verifies that consumption frequency is non-binding metadata.
flashdreams/tests/test_inference_runtime_api.py Migrates the end-to-end runtime API tests to the global-conditioning names and semantics.
flashdreams/tests/test_runtime_canonical.py Updates canonical-input coverage to distinguish direct application-owned global conditioning from live controls.
docs/inference_runtime_api_design.md Clarifies session-global conditioning, per-step messages, and consumption cadence in the high-level design.
docs/inference_runtime_inputs_implementation.md Documents the two encoded input slots and the revised mapping and reset semantics.
docs/inference_runtime_supported_inputs_inventory.md Reclassifies supported model inputs using global-conditioning and per-step scope independently from consumption frequency.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    App[Application or runner] -->|global_conditioning| Session[Inference session state]
    Source[User input source] --> Canonical[Canonical inputs]
    Canonical --> Mapping[Input mapping]
    Mapping -->|step payload| Step[InferenceSession.step]
    Session --> Step
    Step --> Result[StepResult]
    Meta[frequency_consumed: once or per_step] -. adapter query hint .-> Session
Loading

Reviews (1): Last reviewed commit: "Clarify global conditioning input semant..." | Re-trigger Greptile

@aidanfnv
aidanfnv merged commit de51140 into dev/jarcher/inference-runtime-api Aug 6, 2026
3 checks passed
@aidanfnv
aidanfnv deleted the dev/aidanf/T3-global-conditioning-frequency branch August 6, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant