Skip to content

fix(controller): pass task ids to bay get_capacity#13

Merged
shassard-nvidia merged 1 commit into
NVIDIA:mainfrom
rpowers-nv:fix/controller-bay-task-id
May 7, 2026
Merged

fix(controller): pass task ids to bay get_capacity#13
shassard-nvidia merged 1 commit into
NVIDIA:mainfrom
rpowers-nv:fix/controller-bay-task-id

Conversation

@rpowers-nv

@rpowers-nv rpowers-nv commented May 6, 2026

Copy link
Copy Markdown
Contributor

The function interface was expecting the task list to be a list of ids, but the task manager passes a list of task dictionaries. We should change the function to work with task dictionaries or update the manager to pass a list of task ids.

@rpowers-nv rpowers-nv force-pushed the fix/controller-bay-task-id branch from c07c30f to 747a86d Compare May 6, 2026 19:56
@rpowers-nv rpowers-nv changed the title fix(controller): pass task ids to bay get_capacity to avoid unhashabe dict error fix(controller): extract task id in bay get_capacity method May 6, 2026
@shassard-nvidia

Copy link
Copy Markdown
Collaborator

We have some tests in /tests/services/controller/test_bays.py that should probably be adjusted to match this behaviour, such as the test_noavailable_capacity functions.

@rpowers-nv rpowers-nv force-pushed the fix/controller-bay-task-id branch from 0054841 to 4f72680 Compare May 7, 2026 15:22
@rpowers-nv rpowers-nv changed the title fix(controller): extract task id in bay get_capacity method fix(controller): pass task ids to bay get_capacity May 7, 2026
@shassard-nvidia shassard-nvidia merged commit 185adcb into NVIDIA:main May 7, 2026
8 checks passed
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants