Fix PyLucene sidecar packaging and add smoke test#174
Draft
nvzm123 wants to merge 4 commits into
Draft
Conversation
and finish updating cuvs version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on and can supersede #147.
PR #147 adds PyLucene support, but GPU E2E testing exposed several packaging/runtime issues:
cuvs-java, which breaks its multi-release JDK 22 provider classescuvs-javajar on the JVM classpath separately from the cuvs-lucene sidecarThis PR updates the sidecar to include only cuvs-lucene classes and service descriptors, removes Lucene-owned service providers from the cuvs-lucene SPI descriptor, documents the required classpath layout, and adds a PyLucene smoke-test wrapper.
Validation performed on a g5.2xlarge EC2 instance with NVIDIA A10G:
CuVS2510GPUSearchCodecthrough PyLucene.vcag,.vemc)Passing smoke output: