Skip to content

skills: annotate fixed-URL download for Bandit B310 - #2303

Merged
ramakrishnap-nv merged 3 commits into
NVIDIA:mainfrom
ramakrishnap-nv:skills/mps-solver-bandit-b310
Nov 10, 2026
Merged

ramakrishnap-nv merged 3 commits into
NVIDIA:mainfrom
ramakrishnap-nv:skills/mps-solver-bandit-b310

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Summary

Silences Bandit B310 on the MIPLIB air05 download in the mps_solver skill asset. The URL is a fixed https:// constant, so # nosec B310 is justified.

Unblocks the cuopt-numerical-optimization-api re-sign in NVIDIA/skills#855.

Testing

Bandit clean on the file locally. /nvskills-ci to be re-run on this PR.

Docs

N/A

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv ramakrishnap-nv self-assigned this Nov 10, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 10, 2026
@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review November 10, 2026 00:35
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner November 10, 2026 00:35
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: NVIDIA/cuopt
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 0e6e7bf
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 19353015-a171-4dd9-b918-b8923245d976
Commits

Reviewing files that changed from the base of the PR and between e26d029 and 884ba70.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The fixed-URL download call gains a Bandit suppression annotation without changing its behavior. Benchmark reports and signed resource metadata are updated with the evaluation dated 2026-11-10.

Changes: Skill benchmark and download updates

Layer / File(s) Summary
Annotate the download call
skills/cuopt-numerical-optimization-api/assets/python/mps_solver/model.py
The urlretrieve call gains a # nosec B310 annotation. The URL and download behavior remain unchanged.
Update benchmark results and attestation
skills/cuopt-numerical-optimization-api/BENCHMARK.md, skills/cuopt-numerical-optimization-api/skill-card.md, skills/cuopt-numerical-optimization-api/skill.oms.sig
The reports update evaluation metrics, token counts, and finding counts. The signed bundle updates its subject and model digests and adds a README resource.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · previous review e26d0

The download behavior is unchanged. Run the required NVSkills CI before merging to validate the refreshed attestation.

Architecture risk: Low · up to e26d0

The change affects 1 system.

Changed systems: skills

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — skills (service) was modified; 4 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in skills/cuopt-numerical-optimization-api/assets/python/mps_solver/model.py: Added a # nosec B310 annotation to the urlretrieve call; the URL and download behavior remain unchanged.
  • observed — Modified behavior in skills/cuopt-numerical-optimization-api/BENCHMARK.md: The evaluation date changes from 2026-11-09 to 2026-11-10.
  • observed — Modified behavior in skills/cuopt-numerical-optimization-api/BENCHMARK.md: The overall, correctness, discoverability, effectiveness, and efficiency scores change for both agents; security scores remain the same.
  • observed — Modified behavior in skills/cuopt-numerical-optimization-api/BENCHMARK.md: The token-only efficiency comparisons change to Claude Code 97.1% → 96.9% (-0.2 points) and Codex 88.4% → 88.7% (+0.3 points); the discoverability comparison remains N/A.
Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly describes the # nosec B310 annotation for the fixed-URL download, which is the main change.
Description check Passed The description explains the Bandit B310 annotation and the fixed HTTPS URL, so it is related to the changeset.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: NVIDIA/cuopt
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 7d4f913
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: b02efe40-dd6a-4e0d-8f4f-6364f9758c91
Commits

Reviewing files that changed from the base of the PR and between adee5e5 and e26d029.

Files selected for processing: 3

  • skills/cuopt-numerical-optimization-api/BENCHMARK.md
  • skills/cuopt-numerical-optimization-api/skill-card.md
  • skills/cuopt-numerical-optimization-api/skill.oms.sig

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 28 test job(s) passed.

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 884ba70

@ramakrishnap-nv
ramakrishnap-nv merged commit 75cc4da into NVIDIA:main Nov 10, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants