Skip to content

Reduce segmented sort template instantiations #23733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vyasr wants to merge 1 commit into
base: main
Choose a base branch
from
+50 −70
Open

Reduce segmented sort template instantiations #23733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,6 @@ add_library(
src/sort/sort_column.cu
src/sort/sort_radix.cu
src/sort/sorted_order_radix.cu
src/sort/stable_segmented_sort.cu
src/sort/stable_sort_column.cu
src/sort/stable_sort.cu
src/sort/top_k.cu
Expand Down
50 changes: 50 additions & 0 deletions cpp/src/sort/segmented_sort.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,30 @@ std::unique_ptr<table> segmented_sort_by_key(table_view const& values,
values, keys, segment_offsets, column_order, null_precedence, stream, mr);
}

std::unique_ptr<column> stable_segmented_sorted_order(
table_view const& keys,
column_view const& segment_offsets,
std::vector<order> const& column_order,
std::vector<null_order> const& null_precedence,
cuda::stream_ref stream,
rmm::device_async_resource_ref mr)
{
return segmented_sorted_order_common<sort_method::STABLE>(
keys, segment_offsets, column_order, null_precedence, stream, mr);
}

std::unique_ptr<table> stable_segmented_sort_by_key(table_view const& values,
table_view const& keys,
column_view const& segment_offsets,
std::vector<order> const& column_order,
std::vector<null_order> const& null_precedence,
cuda::stream_ref stream,
rmm::device_async_resource_ref mr)
{
return segmented_sort_by_key_common<sort_method::STABLE>(
values, keys, segment_offsets, column_order, null_precedence, stream, mr);
}

} // namespace detail

std::unique_ptr<column> segmented_sorted_order(table_view const& keys,
Expand Down Expand Up @@ -92,4 +116,30 @@ std::unique_ptr<table> segmented_sort_by_key(table_view const& values,
values, keys, segment_offsets, column_order, null_precedence, stream, mr);
}

std::unique_ptr<column> stable_segmented_sorted_order(
table_view const& keys,
column_view const& segment_offsets,
std::vector<order> const& column_order,
std::vector<null_order> const& null_precedence,
cuda::stream_ref stream,
rmm::device_async_resource_ref mr)
{
CUDF_FUNC_RANGE();
return detail::stable_segmented_sorted_order(
keys, segment_offsets, column_order, null_precedence, stream, mr);
}

std::unique_ptr<table> stable_segmented_sort_by_key(table_view const& values,
table_view const& keys,
column_view const& segment_offsets,
std::vector<order> const& column_order,
std::vector<null_order> const& null_precedence,
cuda::stream_ref stream,
rmm::device_async_resource_ref mr)
{
CUDF_FUNC_RANGE();
return detail::stable_segmented_sort_by_key(
values, keys, segment_offsets, column_order, null_precedence, stream, mr);
}

} // namespace cudf
69 changes: 0 additions & 69 deletions cpp/src/sort/stable_segmented_sort.cu
View file
Open in desktop

This file was deleted.

Loading