Skip to content

Handle int64 strings offsets in cudf::byte_cast API - #23725

Open
davidwendt wants to merge 3 commits into
NVIDIA:mainfrom
davidwendt:ls-byte-cast
Open

Handle int64 strings offsets in cudf::byte_cast API#23725
davidwendt wants to merge 3 commits into
NVIDIA:mainfrom
davidwendt:ls-byte-cast

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Fixes logic in the cudf::byte_cast API which converts a strings column into a list column and properly handles int64 offsets by casting them to INT32 if possible.

Reference #23685 (review)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Aug 19, 2026
@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 19, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@davidwendt

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@davidwendt

Copy link
Copy Markdown
Contributor Author

/ok to test

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 809ced67-4971-4848-aa4b-799450a59d27

📥 Commits

Reviewing files that changed from the base of the PR and between 70bf0bc and 1a3593a.

📒 Files selected for processing (1)
  • cpp/src/reshape/byte_cast.cu

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved string byte-casting reliability by ensuring offsets use the correct 32-bit integer format.
    • Added compatibility handling for inputs with different offset types.

Walkthrough

The string byte-casting path now normalizes the offsets column to INT32 before constructing the lists column. The change also adds the required unary utility include and updates the copyright attribution.

Changes

String byte-casting

Layer / File(s) Summary
Normalize offsets before list construction
cpp/src/reshape/byte_cast.cu
The byte-casting path extracts the offsets child and casts it to INT32 when needed before calling make_lists_column. The file adds the unary utility header and updates the SPDX copyright attribution.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 1a359

This localized fix is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: abigalekim

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: handling int64 string offsets in the cudf::byte_cast API.
Description check ✅ Passed The description directly explains the int64 offset handling change and its conversion to INT32 when possible.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 21, 2026
@davidwendt
davidwendt marked this pull request as ready for review August 21, 2026 14:43
@davidwendt
davidwendt requested a review from a team as a code owner August 21, 2026 14:43
@davidwendt
davidwendt requested review from mattgara and qbacpey August 21, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant