Skip to content

Surface code 1 demo refactor followup - #712

Merged
bmhowe23 merged 11 commits into
NVIDIA:mainfrom
eliotheinrich:pr-sc1-followup
Jul 21, 2026
Merged

Surface code 1 demo refactor followup#712
bmhowe23 merged 11 commits into
NVIDIA:mainfrom
eliotheinrich:pr-sc1-followup

Conversation

@eliotheinrich

@eliotheinrich eliotheinrich commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR is a follow-up to #685, addressing the issues in #704 as well as adding a few new CLI args. These new args are purely additive, so this PR should otherwise have identical behavior on the happy paths of #685.

Cleanup

  • Removed mentions of inproc_rpc from realtime_relay_bp.rst
  • Restored MANUALLY_INJECT_ERRORS for quantinuum-emulate path for testing
  • Cleaned up remaining stale references to p_spam, decoding_window, and use-relay-bp
  • Validated geometry of loaded decoder config against requested error model

New features

  • Added support for providing parameters for inner decoder of sliding window decoder
  • Added support for decoder params provided at CLI

Runtime / performance impact

N/A

Self-review checklist

Please confirm each item before requesting review. Check [x] or strike
through and explain.

Before requesting review

  • I reviewed my own full diff in GitHub or my editor.
  • PR is in Draft if it is not yet ready for review.
  • Temporary / debugging changes have been removed.
  • Local test logs reviewed; no unexplained warnings or errors.
  • CI logs reviewed; no unexplained warnings or errors.
  • Full CI has been run.

Scope and size

  • PR is under ~1000 lines, or an exception is justified in the description.
  • Refactoring-only changes are isolated in their own PR(s).
  • No existing tests were disabled or modified just to make this PR pass
    (if so, an issue has been raised).

Tests

  • New functionality has new tests.
  • Tests fail if the new functionality is broken (including crashes), not
    just when it is missing.
  • Negative tests added where exceptions are expected.
  • Truth data added where simple EXPECT_* / assert checks are
    insufficient for algorithmic correctness.
  • CI runtime impact considered; team notified if significant.

Documentation

  • Public-facing APIs have Doxygen docs.
  • User-visible behavior changes have public docs, or a follow-up is
    tracked.

Code style

  • Naming follows the existing convention (snake_case vs camelCase) for
    the area being modified.

Dependencies

  • No new third-party dependencies, or the team has been notified and
    OSRB tickets filed.

eliotheinrich and others added 5 commits July 18, 2026 10:50
…r in sliding window

Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Comment thread docs/sphinx/examples_rst/qec/realtime_decoding.rst
Comment thread docs/sphinx/examples_rst/qec/realtime_relay_bp.rst
Comment thread libs/qec/unittests/realtime/app_examples/CMakeLists.txt Outdated
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@eliotheinrich

Copy link
Copy Markdown
Collaborator Author

/ok to test fe130ac

@eliotheinrich
eliotheinrich marked this pull request as ready for review July 20, 2026 21:18
@bmhowe23

Copy link
Copy Markdown
Collaborator

/ok to test 12edb3c

Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Comment thread libs/qec/unittests/realtime/app_examples/surface_code-1.cpp
Comment thread libs/qec/unittests/realtime/app_examples/surface_code_1.py
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
@bmhowe23

Copy link
Copy Markdown
Collaborator

/ok to test dc4314a

@bmhowe23
bmhowe23 enabled auto-merge (squash) July 21, 2026 00:02
@bmhowe23
bmhowe23 merged commit 87d79f5 into NVIDIA:main Jul 21, 2026
24 checks passed
@bmhowe23 bmhowe23 mentioned this pull request Jul 21, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants