Surface code 1 demo refactor followup - #712
Merged
Merged
Conversation
…r in sliding window Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
…daqx into pr-sc1-followup
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
bmhowe23
reviewed
Jul 20, 2026
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Collaborator
Author
|
/ok to test fe130ac |
eliotheinrich
marked this pull request as ready for review
July 20, 2026 21:18
bmhowe23
approved these changes
Jul 20, 2026
Collaborator
|
/ok to test 12edb3c |
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
…daqx into pr-sc1-followup
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Collaborator
|
/ok to test dc4314a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #685, addressing the issues in #704 as well as adding a few new CLI args. These new args are purely additive, so this PR should otherwise have identical behavior on the happy paths of #685.
Cleanup
inproc_rpcfromrealtime_relay_bp.rstMANUALLY_INJECT_ERRORSfor quantinuum-emulate path for testingp_spam,decoding_window, anduse-relay-bpNew features
Runtime / performance impact
N/A
Self-review checklist
Please confirm each item before requesting review. Check
[x]or strikethrough and explain.
Before requesting review
Scope and size
(if so, an issue has been raised).
Tests
just when it is missing.
EXPECT_*/assertchecks areinsufficient for algorithmic correctness.
Documentation
tracked.
Code style
snake_casevscamelCase) forthe area being modified.
Dependencies
OSRB tickets filed.