Repository navigation
Conversation
Signed-off-by: Raul Estrada <raulestradaa@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1451
api::fullcurrently uses unchecked multiplication to calculate its flattened element count. Invalid shapes can panic during construction or wrap before allocation and initialization, with shape validation occurring later duringreshape.Validate the element count with checked multiplication and reject zero dimensions and flattened lengths above
i32::MAX. Invalid inputs returnDeviceError::Internalwhen the operation executes, before GPU allocation or kernel execution.zerosandonesinherit the validation throughfull.Add five host tests and three GPU tests covering overflow, zero dimensions, the
i32boundary, construction without panics, and valid tensor shapes and values. Preserve scalar shape[].Validation
Run from
cutile-rs:All commands passed. The serial full run passed CPU and GPU tests, 24 examples, and all eight benchmark smoke tests. Three examples were skipped because they require newer Tile IR versions.
The default parallel run failed in
warmup_composed::composed_builder_compile_terminal_warms_the_dispatched_specialization, with a JIT compile count of 17 instead of 18. That test passed in isolation, and all 16warmup_suitetests passed serially. These results suggest a cache state or test ordering dependency; no warmup code is changed in this PR.