Repository navigation
Conversation
Signed-off-by: Raul Estrada <raulestradaa@gmail.com>
uurl
force-pushed
the
fix/recursive-packed-as3-local-projections
branch
from
October 8, 2026 04:51
f210339 to
818c88d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1094
Summary
Extend the packed-AS3 carrier-local contract introduced by #1327 to support:
The implementation preserves #1327's closed-world model: the complete MIR address-use graph is validated before dialect conversion, and lowering-private physical type facts are attached only after the whole graph succeeds.
Carrier identity is never reconstructed from LLVM defining operations,
OperandsInfo, or converted GEP history.Representation and projection contract
Semantic values retain AS3 pointers while compiler-owned local storage uses the target-stable generic-pointer carrier:
Conversions remain explicit at load/store boundaries.
The verified address graph now admits:
Each projection derives its physical pointee from the already-proven parent carrier type.
mir.field_addrsupports recursive struct/tuple projections, andmir.array_element_addruses the verified physical carrier element type. Ordinary non-carrier addressing is unchanged.Bounds and fail-closed behavior
The existing 16-leaf array rewrite budget is reused. Local-storage shape admission remains independently classified, so future internal-ABI shape widening cannot implicitly widen carrier-local support.
Carrier addresses still fail closed across:
AS3 pointer vectors and arbitrary packed-AS3 memory remain unsupported.
Tests
Added focused coverage for:
packed_aggregate_abinow exercises multiple direct leaves, nested structs, nested tuples, and bounded AS3 pointer arrays through carrier-local projections.Validation
Results:
Both optimized and
CUDA_OXIDE_NO_OPT=1packed_aggregate_abiexecutions pass.addressof_sharedarrayalso continues to pass.Out of scope
This PR does not add carrier-address transport through calls, block arguments, casts, returns, or arbitrary pointer arithmetic, nor support for AS3 pointer vectors, arbitrary/device-global/kernel-entry packed-AS3 carrier storage, or AS3-containing enum locals.