Repository navigation
Conversation
midagedev
force-pushed
the
fix/atomic-backend-install
branch
from
September 25, 2026 00:13
cada00a to
f4a5ec9
Compare
install_backend_into copied the new backend over the cached .so with fs::copy. That truncates and rewrites the same inode, so a rustc that already loaded the old file can die with SIGBUS. Copy to a temporary file in the cache dir, then rename it over the .so. If the copy or the rename fails, remove the temporary file and return the error. Tests: an open handle keeps reading the old bytes and inode after an install; a failed copy or rename leaves the old .so and no temporary file. Signed-off-by: midagedev <midagedev@gmail.com>
midagedev
force-pushed
the
fix/atomic-backend-install
branch
from
October 8, 2026 02:44
f4a5ec9 to
95d1174
Compare
nihalpasham
added
the
cuda-oxide
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_backend_intocopies over the cached.sowithfs::copy. That rewrites the same inode, so arustcthat loaded it can die with SIGBUS. Two parallelcargo oxide buildruns hit this.Changes
fs::renameit over the.so. On error, remove it.Testing
Verified at
f4a5ec9e: 242 cargo-oxide host tests, Clippy, fmt, doc, guards. A reader that mmaps the.soduring a secondcargo oxide setup: SIGBUS 3/3 before, 0/3 after. Not run:just check, examples.AI (Claude) helped write this change.
just checkpasses (the local mirror of CI: fmt, clippy, tests, guards, docs)cargo oxide run <example>passes, orscripts/smoketest.sh -o '^<example>$'Checklist
git commit -s)