Repository navigation
fix(rustlantis): drop the removed box_patterns feature gate - #1262
Merged
nihalpasham merged 1 commit intoSep 18, 2026
Merged
Conversation
nightly-2026-08-28, pinned in NVIDIA#1201, removed the `box_patterns` feature, so the vendored `mir` crate fails with E0557 and neither `generate` nor `tools/mir_generator.py` builds. Nothing in the crate uses box patterns. The rustlantis workspace is not built in CI, so the break went unnoticed. Signed-off-by: sachin <sachinsharma3191@gmail.com>
nihalpasham
force-pushed
the
fix/rustlantis-box-patterns
branch
from
September 18, 2026 03:48
86baab7 to
eea1582
Compare
nihalpasham
added
bug
nihalpasham
reviewed
Sep 18, 2026
Collaborator
There was a problem hiding this comment.
I kept the one-line build fix and rebased and signed the contributor commit.
Restoring the removed feature gate reproduces E0557 on the pinned nightly. With it removed, all 24 MIR/generator tests pass and the Python adapter generates seed 1. Strict Clippy still stops on the existing abi/src/size.rs lint.
This restores the generator after the toolchain update in #1201 and supplies the prerequisite for #1263.
Checked at eea15821. Hosted CI also passes on this head.
nihalpasham
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The Rustlantis generator builds again on the pinned
nightly-2026-08-28. That nightly removedbox_patterns; the vendored MIR crate still enabled it even though it contains no box patterns.What changed
Removed the unused feature gate. I rebased and signed the contributor commit, preserving its author and sign-off.
Verification
Checked at
eea15821:Strict Clippy in this vendored workspace still stops in unchanged
abi/src/size.rsonmanual_div_ceil. This change does not resolve that existing lint debt.Related to the toolchain update in #1201. #1263 shares this prerequisite commit.