Repository navigation
fix(intrinsics): decouple remaining ABI IDs from variant order - #1093
Merged
Merged
Conversation
Signed-off-by: Raul Estrada <raulestradaa@gmail.com>
5 tasks done
Collaborator
|
Verified complete:
This is the #1038 remainder and closes #604. Sequencing, important: #1139 reintroduces this pattern ( On our side at landing: the byte-identical claim was made on a 2026-08-20 base and main has merged #1104/#1085 since (both touched resolve.rs), so we rerun |
nihalpasham
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604
Summary
Finish decoupling compact-family ABI assignment from canonical variant
position.
The remaining register MMA, sparse MMA, and cluster-sreg expansions now leave
generated ABI IDs unbound and rely on the existing ABI ledger binding by
catalog identity.
Canonical admission checks continue to enforce semantic membership, ordering,
and completeness, but no longer derive ABI identity from variant position.
This completes the remaining positional ABI-ID coupling described in #604,
following #1038.
Validation
cargo fmt --all -- --checkcargo test -p cuda-intrinsics-gen(293 passed)cargo run -p cuda-intrinsics-gen -- checkcargo run -p cuda-intrinsics-gen -- check-abi-history --base-ref upstream/maingit diff --check upstream/main..HEADintrinsics/abi-v1.tomlunchanged