Skip to content

Backport CFITSIO wheel licensing fix to 0.2.x - #191

Closed
tpn wants to merge 1 commit into
0.2.xfrom
codex/cfitsio-wheel-notices-02x-20261112
Closed

tpn wants to merge 1 commit into
0.2.xfrom
codex/cfitsio-wheel-notices-02x-20261112

Conversation

@tpn

@tpn tpn commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Backports #190 to 0.2.x; land after the main PR.

Build the wheel's bundled CFITSIO without unused Fortran wrappers, preserve the retained Bison parser notice and exception, and check the resulting exports and license metadata. The release branch's README and versioning configuration are preserved.

Validation: 107 focused tests and repository hooks pass. The source archive passes strict Twine and distribution checks. The same recipe passed 54 upstream CFITSIO tests plus C API FITS, expression-parser, and reentrant checks. Native wheel qualification is running on #190.

Build the bundled library with the C API only and preserve the retained
Bison parser notice and exception in distributions. Require the notice
and C-only exports when checking repaired wheels.

Signed-off-by: Trent Nelson <trentn@nvidia.com>
(cherry picked from commit 2bb2715)
Signed-off-by: Trent Nelson <trentn@nvidia.com>
@tpn
tpn requested a review from melo-gonzo as a code owner November 12, 2026 17:18
@tpn tpn added the ai-review Request a focused CodeRabbit review label Nov 12, 2026
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1

  • ^codex/013-.*$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

@melo-gonzo melo-gonzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same change as #190. The two patches match line for line except one context line in pyproject.toml, where this branch keeps readme = "README-pypi.md". tests/test_distribution_licenses.py passes 43 tests here. CI built the wheels with cfitsio: Building without Fortran support, and check_distributions.py passed on them.

The considerations from my #190 review apply here too. The C API symbol requirement and the invalid-ELF exit in check_cfitsio_symbols have no failing test. The GPL-with-exception term in the wheel License-Expression can trip some license scanners. The GPU jobs were still pending when I checked.

Checks at 5b09c83
diff of (git diff main..#190) and (git diff 0.2.x..#191), index lines removed:
809c809
<  readme = "README.md"
---
>  readme = "README-pypi.md"

tests/test_distribution_licenses.py -> 43 passed

@tpn tpn closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a focused CodeRabbit review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants