Repository navigation
Conversation
Build the bundled library with the C API only and preserve the retained Bison parser notice and exception in distributions. Require the notice and C-only exports when checking repaired wheels. Signed-off-by: Trent Nelson <trentn@nvidia.com> (cherry picked from commit 2bb2715) Signed-off-by: Trent Nelson <trentn@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
melo-gonzo
left a comment
There was a problem hiding this comment.
This is the same change as #190. The two patches match line for line except one context line in pyproject.toml, where this branch keeps readme = "README-pypi.md". tests/test_distribution_licenses.py passes 43 tests here. CI built the wheels with cfitsio: Building without Fortran support, and check_distributions.py passed on them.
The considerations from my #190 review apply here too. The C API symbol requirement and the invalid-ELF exit in check_cfitsio_symbols have no failing test. The GPL-with-exception term in the wheel License-Expression can trip some license scanners. The GPU jobs were still pending when I checked.
Checks at 5b09c83
diff of (git diff main..#190) and (git diff 0.2.x..#191), index lines removed:
809c809
< readme = "README.md"
---
> readme = "README-pypi.md"
tests/test_distribution_licenses.py -> 43 passed
Backports #190 to
0.2.x; land after the main PR.Build the wheel's bundled CFITSIO without unused Fortran wrappers, preserve the retained Bison parser notice and exception, and check the resulting exports and license metadata. The release branch's README and versioning configuration are preserved.
Validation: 107 focused tests and repository hooks pass. The source archive passes strict Twine and distribution checks. The same recipe passed 54 upstream CFITSIO tests plus C API FITS, expression-parser, and reentrant checks. Native wheel qualification is running on #190.