Make report_frequency general configuration block argument actually optional.#102
Merged
romerojosh merged 1 commit intomasterfrom Feb 5, 2026
Merged
Make report_frequency general configuration block argument actually optional.#102romerojosh merged 1 commit intomasterfrom
romerojosh merged 1 commit intomasterfrom
Conversation
…ptional. Signed-off-by: Josh Romero <joshr@nvidia.com>
Collaborator
Author
|
/build_and_test |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While putting together tests for #98, I found that the
report_frequencyconfiguration file entry is not optional if ageneralblock is present. For example, a general block withoutreport_frequencylike the following:will throw an uncaught exception because we unconditionally check the
report_frequencyvalue if ageneralblock exists in the configuration file.This PR adds the appropriate try/catch block around checking the value of
report_frequencyto fix this issue.