Conversation
Signed-off-by: Deepak Jain <deepujain@gmail.com>
The bounded-gap patterns used '.' which does not match newlines in YARA regexes, so socket creation and .connect() on separate lines never matched. Add the 's' (dotall) modifier to the python_socket and perl_socket patterns so multiline forms are detected. Fixes the two failing parametrized cases in test_builtin_reverse_shell_matches_multiline_socket_forms. Signed-off-by: Deepak Jain <deepujain@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #592 by bounding the Python and Perl socket reverse-shell YARA expressions across multiline source.
Validation
ruff check tests/nodes/analyzers/test_static_yara.pyruff format --check tests/nodes/analyzers/test_static_yara.pyRisk
The bounded 200-character spans preserve proximity between socket creation and connection, avoiding an unbounded cross-file match.