feat(tier3): upgrade Harbor to 0.22.0 - #83
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
One blocking merge-integration issue remains. Exact-head CI and DCO are green, but the collector conflict with current main must be resolved semantically before this can merge.
| agent_reason = _agent_log_runtime_failure_reason( | ||
| trial_dir, | ||
| include_text_logs=bool(exception_reason), | ||
| include_text_logs=any(reason for _exception_type, reason in exception_details), |
There was a problem hiding this comment.
[P1] Preserve the exception-type gate from current main\n\nThis scans plain agent transcripts whenever any root/step exception has a message. After merging current main, a verifier/healthcheck/task failure plus harmless agent prose such as 401 Unauthorized is therefore reported as an agent runtime failure, reintroducing the bug fixed by #84. I reproduced that on this head. Please rebase and enable text-log scanning only when at least one root/step exception_type is in _AGENT_RUNTIME_EXCEPTION_TYPES or _UNCONDITIONAL_AGENT_RUNTIME_EXCEPTION_TYPES; keep the JSON type=error and trajectory paths unchanged.
|
@chrisknvidia Gentle ping when you have a chance: the remaining review thread is still waiting for an update or response. Please take a look when you can. |
Closes #79
Summary
custom_onlymode.Harbor v0.22.0 is the latest upstream release as of 2026-08-26: https://github.com/harbor-framework/harbor/releases/tag/v0.22.0
Verification through
ca3e731The full local suites, packaging gates, and real Harbor runs below were collected on implementation snapshot
8b0110f. Follow-upsa783c2aandca3e731are limited to a behavior-preserving helper rename plus persistence assertion and a portable test invocation; focused local regressions and the complete exact-head GitHub matrix cover those diffs.Automated
6378 passed, 19 skipped, 9 deselectedin 594.56s.6378 passed, 19 skipped, 9 deselectedin 578.52s.7 passedin 52.58s.350 passed, 4 skipped; direct report regression slice:11 passed.241 passedin 39.56s; public benchmark gate passed.harbor.__version__ == "0.22.0".git diff --checkpassed. The repository-wide format check still lists 18 files, all byte-identical toorigin/main.pip-audit: no known vulnerabilities (the unpublished localskillevaluatorpackage is skipped). Path-aware Gitleaks scans passed for the tracked diff and all 30 branch commits.trustedtostructural; persistence coverage now also proves that all runner-internal underscore metadata is omitted fromreward.json. Focused identity tests:3 passed; long stop-on-pass merge path:1 passed; broader collector suites:176 passed.bashto the WSL launcher instead of a POSIX shell. The isolation test now invokes the staged evaluator withsys.executable -Ion every OS while separately asserting the generated shell contract; the full isolation/judge slice passed with459 passed, 2 skipped.1292 passed, 30 skipped), native-Windows fail-closed, macOS Tier 2/Tier 3, RHEL 8, packaging, dependency review, DCO, Gitleaks, the Security CodeQL job, and the separate GitHub CodeQL gate. Alert fix: upgrade langchain-core for CVE-2026-45134 #10 isfixedby fresh analysis with zero results; it was not dismissed or suppressed.Real Harbor 0.22 integration paths
Native Harbor BYOT / Docker / Codex / custom-only / skip baseline
selector-attempt2), logical entry ID (logical-attempt9), and display name (publisher/display-attempt7) remained distinct.overall=1.0andnative_quality=1.0; the staged task contained only the intended step-local test overlay.Generated dataset / Docker / Codex / runtime setup / unified reports
custom_onlyand--skip-baseline.runtime_envvalue reached the verifier, and two pre-agent setup commands persisted an independently checked artifact before agent execution.canary_protocol=1.0andruntime_setup=1.0; 1/1 expected/scored attempt; no baseline or lift was synthesized.succeeded, overall 1.0, and both custom metrics; HTML contains both evaluator cards; Markdown records the overall passed validation and completed Tier 3 stage. The Tier 3 verdict is correctly neutral because this was custom-only, skip-baseline evidence with no lift.Native Harbor BYOT / local / OpenCode / NVIDIA Build / custom-only
overall=1.0,native_quality=1.0; logical attempt accounting correctly recorded actual attempt 1 despiteattempt-like selector/ID text.Generated dataset / Docker / Codex / paired baseline / standard + custom grading
Exact provider-key scans found no configured provider credential in retained real-run artifacts. Temporary E2E fixtures/results were removed from the worktree after inspection; no fixture or generated runtime token is included in this branch.
Review
a783c2a.Remaining verification gaps
Draft status
This PR remains intentionally draft. Exact-head remote CI passed all 15 checks on
ca3e731. Do not mark ready or merge until maintainer review is complete.