fix(cli): report malformed policy files cleanly - #129
Open
rioyu123 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Rio Yu <52408936+rioyu123@users.noreply.github.com>
rioyu123
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
September 1, 2026 02:24
Signed-off-by: Rio Yu <52408936+rioyu123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Malformed, non-UTF-8, deeply nested, or unreadable bundled and custom policy files now follow a path-specific error contract. The CLI converts those failures into concise Click errors instead of exposing raw parser, decoder, recursion, or I/O exceptions.
The change uses one private loader helper for both policy paths, preserves the original exception as the cause, keeps
FileNotFoundErrorbehavior unchanged, and does not fall back to a default policy after an explicit invalid--policyinput.Fixes #128.
Verification
Focused verification:
\\tmp\\runversus/tmp/run)Release Impact