fix: treat tools/ as an executable directory - #103
Conversation
Schema already allows tools/ as the agentskills.io name for helpers, but quality scoring, script lint, and create-eval-dataset only looked at scripts/. A spec-compliant skill with tools/run.py was typed as guide-only, skipped lint, and generated Scripts: none. Fixes NVIDIA#89 Signed-off-by: mimran-khan <mohammed_imran.khan@outlook.com>
rng1995
left a comment
rng1995
left a comment
There was a problem hiding this comment.
Reviewed the exact current head against #89. tools/ is handled consistently with scripts/ in type detection, reliability scoring, script lint, and dataset generation, while being excluded from library-module discovery. Focused tests pass (163), with Ruff and diff checks clean. No actionable findings; approved. The red Gitleaks job is unrelated branch history.
|
@mimran-khan - Please resolve merge conflicts |
|
Merged main in. Changelog conflict is resolved. |
# Conflicts: # CHANGELOG.md
|
Merged latest main (including #102) and resolved the CHANGELOG conflict. Ready for another look. |
|
Please resolve merge conflict in CHANGELOG.md so that I can merge it. Thanks for your contribution and patience @mimran-khan |
Head branch was pushed to by a user without write access
3 participants
Summary
Schema already allows
tools/as the agentskills.io name for helpers. Quality scoring, script lint, andcreate-eval-datasetonly looked atscripts/, so a spec-compliant skill withtools/run.pycame back as guide-only, skipped lint, and generatedScripts: none.Those three now look at
scripts/andtools/. Fixes #89.Verification
make lintmake testmake buildRelease Impact
CHANGELOG.md