Allow setting custom inference timeout#656
Closed
pentschev wants to merge 3 commits intoNVIDIA:mainfrom
Closed
Conversation
|
Thank you for your interest in contributing to OpenShell, @pentschev. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the inference routing timeout configurable via
openshell inference set --timeout <secs>andopenshell inference update --timeout <secs>, replacing the hardcoded 60-second default. Timeout changes propagate dynamically to running sandboxes within the route refresh interval (~5 seconds) without requiring sandbox recreation.The timeout was observed running OpenCode for a complex build task on a DGX Spark running nemotron-3-super:120b via Ollama, this feature allows longer running tasks to succeed.
Related Issue
Closes #641
Changes
timeout_secsfield toClusterInferenceConfig,SetClusterInferenceRequest,SetClusterInferenceResponse,GetClusterInferenceResponse, andResolvedRouteproto messagestimeoutfield (Duration) to the router'sResolvedRoutestruct with aDEFAULT_ROUTE_TIMEOUTof 60 secondsreqwest::Clienttimeout; apply per-request.timeout(route.timeout)inbackend.rstimeout_secsthrough server persistence (upsert_cluster_inference_route,build_cluster_inference_config, bundle resolution)timeout_secsto routerResolvedRoute.timeoutin the sandbox'sbundle_to_resolved_routes()timeout_secsin the bundle revision hash so timeout changes trigger route cache refreshes in running sandboxes--timeoutCLI flag toinference set(default 0 = 60s) andinference update(optional)docs/inference/configure.mdwith timeout usage and hot-reload behaviorarchitecture/inference-routing.mdwith per-request timeout semantics, proto field additions, and CLI surfaceTesting
mise run pre-commitpassesChecklist