-
Notifications
You must be signed in to change notification settings - Fork 797
feat(sandbox,providers): add aws-bedrock as a recognized inference provider #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
st-gr
wants to merge
2
commits into
NVIDIA:main
Choose a base branch
from
st-gr:feat/aws-bedrock-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| use crate::ProviderDiscoverySpec; | ||
|
|
||
| pub const SPEC: ProviderDiscoverySpec = ProviderDiscoverySpec { | ||
| id: "aws-bedrock", | ||
| credential_env_vars: &[ | ||
| "AWS_ACCESS_KEY_ID", | ||
| "AWS_SECRET_ACCESS_KEY", | ||
| "AWS_SESSION_TOKEN", | ||
| "AWS_REGION", | ||
| ], | ||
| }; | ||
|
|
||
| test_discovers_env_credential!( | ||
| discovers_aws_bedrock_env_credentials, | ||
| "AWS_ACCESS_KEY_ID", | ||
| "AKIA-test-key" | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| id: aws-bedrock | ||
| display_name: AWS Bedrock | ||
| description: Anthropic + Mistral + Llama models served via the AWS Bedrock InvokeModel API | ||
| category: inference | ||
| inference_capable: true | ||
| credentials: | ||
| - name: aws_access_key_id | ||
| description: AWS access key id used for SigV4 signing of outbound Bedrock requests | ||
| env_vars: [AWS_ACCESS_KEY_ID] | ||
| required: true | ||
| - name: aws_secret_access_key | ||
| description: AWS secret access key paired with aws_access_key_id | ||
| env_vars: [AWS_SECRET_ACCESS_KEY] | ||
| required: true | ||
| - name: aws_session_token | ||
| description: Optional session token for temporary credentials (STS, IAM Roles for Service Accounts) | ||
| env_vars: [AWS_SESSION_TOKEN] | ||
| required: false | ||
| - name: aws_region | ||
| description: AWS region the Bedrock endpoint resolves into (e.g. us-east-1) | ||
| env_vars: [AWS_REGION, AWS_DEFAULT_REGION] | ||
| required: true | ||
| discovery: | ||
| credentials: [aws_access_key_id, aws_secret_access_key, aws_region] | ||
| endpoints: | ||
| # Default endpoint targets us-east-1 since the YAML loader does not yet | ||
| # substitute the `{region}` placeholder. Operators in other regions | ||
| # override via the `BEDROCK_BASE_URL` config-key the same way the | ||
| # `anthropic` provider accepts `ANTHROPIC_BASE_URL`. | ||
| - host: bedrock-runtime.us-east-1.amazonaws.com | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can also use wildcards/glob patterns here unless you feel that is too broad of access |
||
| port: 443 | ||
| protocol: rest | ||
| access: read-write | ||
| enforcement: enforce | ||
| binaries: [/usr/bin/claude, /usr/local/bin/claude] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove legacy provider updates, we should only be relying on providers v2 changes which should NOT require any changes to the discovery specs.