fix(helm): create sandbox JWT secret when cert-manager is enabled#1700
Open
TaylorMutch wants to merge 1 commit into
Open
fix(helm): create sandbox JWT secret when cert-manager is enabled#1700TaylorMutch wants to merge 1 commit into
TaylorMutch wants to merge 1 commit into
Conversation
The cert-manager install path (certManager.enabled=true, pkiInitJob.enabled=false) left the gateway StatefulSet unable to start because nothing created the openshell-jwt-keys Secret: cert-manager owns TLS Secrets but does not mint the sandbox JWT signing key, and the certgen hook only rendered when pkiInitJob.enabled was true. Separate JWT signing-key provisioning from TLS PKI provisioning: - certgen: add a --jwt-only mode that creates only the Opaque JWT signing Secret, for use when another controller owns TLS Secrets. - certgen.yaml: render the hook when pkiInitJob.enabled OR certManager.enabled is true. cert-manager takes precedence and runs the hook with --jwt-only even if pkiInitJob.enabled remains true. Remove the mutual-exclusion failure between the two values. - _helpers.tpl: add openshell.sandboxJwtSecretName, shared by the hook and the StatefulSet mount. - Update values, README, docs, architecture, and the debug-openshell-cluster skill to reflect the new precedence; the documented cert-manager install no longer needs pkiInitJob.enabled=false. Closes #1691
|
🌿 Preview your docs: https://nvidia-preview-pr-1700.docs.buildwithfern.com/openshell |
|
Label |
TaylorMutch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cert-manager install path left the gateway StatefulSet unable to start because nothing created the
openshell-jwt-keysSecret. cert-manager owns TLS Secrets but does not mint the sandbox JWT signing key, and the certgen hook only rendered whenpkiInitJob.enabledwas true. This PR separates sandbox JWT signing-key provisioning from TLS PKI provisioning so the JWT Secret always exists.Related Issue
Closes #1691
Changes
--jwt-onlymode that creates only the Opaque JWT signing Secret, for use when another controller (cert-manager) owns the TLS Secrets.pkiInitJob.enabledorcertManager.enabledis true. cert-manager takes precedence and runs the hook with--jwt-onlyeven ifpkiInitJob.enabledremains true. Removes the old mutual-exclusion failure between the two values.openshell.sandboxJwtSecretName, shared by the hook and the StatefulSet mount.--set pkiInitJob.enabled=false. Updatedmanaging-certificates.mdx,openshift.mdx,architecture/gateway.md, and thedebug-openshell-clusterskill.tests/certgen_test.yamlHelm unit suite (combined, JWT-only, custom secret name, both-enabled precedence) and a CLI parse test for--jwt-only.Testing
mise run pre-commitpassesChecklist