Skip to content

feat(snap): add OpenShell icon to meta/gui/#1693

Open
zyga wants to merge 1 commit into
NVIDIA:mainfrom
zyga:feature/icon
Open

feat(snap): add OpenShell icon to meta/gui/#1693
zyga wants to merge 1 commit into
NVIDIA:mainfrom
zyga:feature/icon

Conversation

@zyga
Copy link
Copy Markdown
Contributor

@zyga zyga commented Jun 2, 2026

Summary

Add an openshell snap desktop application running "openshell term" in the default platform terminal.

Related Issue

#1674 although more changes are coming in a 2nd branch

Changes

  • add the existing snap icon
  • add a desktop file for openshell.term
  • add the new openshell.term application entry to snapcraft.yaml

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Add a desktop launcher for the OpenShell TUI so users can launch
"openshell term" from their desktop environment application menu.

The change adds three files:
- snap/local/term.desktop: desktop entry file for the application launcher
- snap/local/icon.png: application icon (copied from snap store data)
- snapcraft.yaml: new "term" app entry that runs "openshell term"
  with home, network, ssh-keys, and system-observe plugs, plus install
  rules to stage the desktop file and icon under meta/gui/

The desktop file references the icon via ${SNAP} which is resolved
at runtime to the snap installation directory. The term app reuses
the same connection plugs as the main openshell app.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@zyga zyga requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners June 2, 2026 20:30
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jun 2, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@TaylorMutch
Copy link
Copy Markdown
Collaborator

/ok to test 1ba6eda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants