Skip to content

refactor(driver): trim compute capability response#1402

Merged
drew merged 1 commit into
mainfrom
cleanup-driver-capabilities-en
Jun 2, 2026
Merged

refactor(driver): trim compute capability response#1402
drew merged 1 commit into
mainfrom
cleanup-driver-capabilities-en

Conversation

@elezar
Copy link
Copy Markdown
Member

@elezar elezar commented May 15, 2026

Summary

Remove unused GPU availability fields from the internal compute driver capability response. GPU admission remains driver-local and is still validated when a sandbox create request asks for GPU resources.

This intentionally breaks wire compatibility for the internal compute-driver capability message by deleting the removed fields without reserving their field numbers or names.

Related Issue

None.

Changes

  • Removed the compute-driver capability proto fields for GPU support and GPU count without reserving their tags or names.
  • Stopped populating GPU capability fields from Docker, Kubernetes, Podman, VM, and test drivers.
  • Documented that the capability RPC reports driver identity, version, and default image only.
  • Addressed clippy fallout from the now-sync Kubernetes capability path.

Testing

  • cargo check -p openshell-core -p openshell-driver-docker -p openshell-driver-kubernetes -p openshell-driver-podman -p openshell-driver-vm -p openshell-server
  • cargo test -p openshell-server -p openshell-driver-docker -p openshell-driver-kubernetes -p openshell-driver-podman -p openshell-driver-vm --no-run
  • mise run pre-commit passes
  • Unit tests not applicable; no behavior change beyond removing unused capability fields
  • E2E tests not applicable; no sandbox runtime behavior change

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar elezar requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 15, 2026 15:02
Comment thread proto/compute_driver.proto
@elezar elezar mentioned this pull request May 20, 2026
9 tasks
@elezar elezar force-pushed the cleanup-driver-capabilities-en branch from f76f3f4 to cd6c738 Compare May 20, 2026 14:20
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the cleanup-driver-capabilities-en branch from cd6c738 to e70e37e Compare May 28, 2026 18:08
@elezar elezar requested a review from TaylorMutch June 2, 2026 08:16
@drew drew merged commit 79aa355 into main Jun 2, 2026
25 checks passed
@drew drew deleted the cleanup-driver-capabilities-en branch June 2, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants