docs: restructure spark-install.md for clearer onboarding flow#857
docs: restructure spark-install.md for clearer onboarding flow#857cv merged 3 commits intoNVIDIA:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughspark-install.md reorganized: Overview and Prerequisites moved earlier; Quick Start updated to reflect installer-managed Node.js/OpenShell and a setup script for cgroup/Docker fixes; Troubleshooting consolidated with Known Issues and Manual Setup fallback; Local Inference steps renumbered; Architecture label simplified and Docker version removed. (49 words) Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@spark-install.md`:
- Line 11: Replace the hardcoded Docker minor version string in the markdown
lines that read "**Docker** (pre-installed on DGX Spark, v28.x)" (and the
identical occurrences further down) with a generic, non-version-specific
phrasing such as "**Docker** (pre-installed on DGX Spark)" or "Docker
(pre-installed)" so the docs do not assert a specific minor stream; update all
instances of that exact phrase to remove the "v28.x" pin and leave a neutral
statement about Docker being pre-installed.
- Around line 12-13: Update the documentation text that currently states
"OpenShell CLI (installed automatically by the NemoClaw installer)" to clarify
that OpenShell is NOT installed by the NemoClaw installer and must be installed
separately before running NemoClaw; reference the installer script invocation
(./install.sh) and the runtime check in the code
(nemoclaw/src/blueprint/runner.ts which will throw "openshell CLI not found.
Install OpenShell first") so users know to pre-install OpenShell prior to
running the installer or NemoClaw.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 88971c2e-4ff6-4b23-a1a6-4f3a155de4e2
📒 Files selected for processing (1)
spark-install.md
ed74697 to
48424e0
Compare
|
@coderabbitai resume |
|
✅ Actions performedReviews resumed. |
✅ Actions performedReviews resumed. |
f79c188 to
3b41d7d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@spark-install.md`:
- Around line 32-33: Remove the incorrect parenthetical claim "(this also
installs OpenShell if needed)" in the line that contains the hosted install
command curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash so the sentence
only advertises the hosted install script (which installs Node.js, Ollama if GPU
present, and NemoClaw) and does not mention OpenShell.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df21a56f-e242-437f-af25-b77c0ff17cea
📒 Files selected for processing (1)
spark-install.md
713d891 to
a189c2f
Compare
|
Looking at it it is still confusing. If I want to use local inference and go through it step by step, I read it now as if I first need to install it with external API reference, then uninstall, then install it again after installing Ollama locally. |
Good catch , you're right, the flow reads as install >uninstall > install Ollama > reinstall, which is confusing and unnecessary for someone who knows upfront they want local inference. Fixed em in the latest push |
66c641a to
e1027f2
Compare
Reorder sections from the current confusing layout into a logical progression: Overview → Prerequisites → Quick Start → Verify → Troubleshooting → Technical Reference. - Add brief overview paragraph explaining what the guide covers - Clarify that OpenShell is installed automatically (not a manual prerequisite) - Remove redundant OpenShell install step from Quick Start - Number Ollama setup steps for easier navigation - Group Known Issues and Manual Setup under a Troubleshooting section - Move What's Different on Spark and Architecture into Technical Reference Fixes NVIDIA#711
Address reviewer feedback: make it clear that an API key is only needed for cloud inference, link to the Local Inference section from Prerequisites, and restructure step 5 so users who haven't installed yet don't need to uninstall/reinstall.
e1027f2 to
0185e5e
Compare
prekshivyas
left a comment
There was a problem hiding this comment.
Clean restructure — the new flow (Prerequisites → Quick Start → Verify → Troubleshooting → Technical Reference) matches how a user actually works through setup. Numbering the Ollama steps and consolidating troubleshooting under one section are nice improvements. LGTM.
Slot PR NVIDIA#885 content into NVIDIA#857 structure per reviewer: known-issue rows to Troubleshooting, Web Dashboard and NIM arm64 to Technical Reference, hardware details to Prerequisites and Architecture diagram.
Resolves #711
The current
spark-install.mddrops users into a Quick Start beforethey've confirmed prerequisites, buries troubleshooting behind
architecture notes, and scatters related information across
disconnected sections. This makes first-run setup on DGX Spark harder
to follow than it needs to be.
This PR reorders and lightly restructures the doc without changing any
of the actual instructions or commands:
→ Technical Reference — matches the order a user actually works
through during setup.
removing the standalone
curlstep from Quick Start that implied itwas a manual prerequisite.
sequential walkthrough instead of a flat list of headings.
Troubleshooting section — the first place users look when something
breaks.
into a Technical Reference section at the bottom for anyone who wants
the context without it blocking the happy path.
No functional changes — only section ordering, heading hierarchy, and
a short introductory paragraph were added.
Summary by CodeRabbit