perf: reduce sandbox image build time and size during onboarding#855
Open
perf: reduce sandbox image build time and size during onboarding#855
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 Walkthrough🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce NemoClaw sandbox image build cost during onboarding without changing functionality or weakening the current security model.
This PR keeps the existing monolithic image approach, but trims unnecessary build/runtime overhead and adds a repeatable benchmark for comparing image build performance against
origin/main.What Changed
nemoclaw-blueprint/.venvfrom the staged contextnpm installto lockfile-backednpm cipython3-pippython3-venviproute2PyYAMLorigin/mainvs current branch sandbox image buildsSecurity / Behavior
This PR is intentionally scoped to image build optimization and does not change the core security model.
Preserved:
openclaw.json/ config-hash protectionSecurity validation still passes, including the gateway isolation end-to-end test.
Validation
Repo checks:
npx vitest run test/sandbox-build-context.test.js test/onboard.test.js test/security-c2-dockerfile-injection.test.js test/credential-exposure.test.js test/runner.test.jsgit diff --checkbash -n test/e2e-test.sh test/e2e-gateway-isolation.shContainer/security checks:
bash test/e2e-gateway-isolation.sh10 passed,0 failedBenchmark:
node scripts/benchmark-sandbox-image-build.jsLatest result:
main (93a475a):74.2s,1493.0 MiBcandidate:40.8s,1165.7 MiBDelta:
33.4sfaster327.3 MiBsmallerFollow-up
The next larger step is tracked separately in #854:
nemoclaw-baseimageSummary by CodeRabbit
Chores
New Tools
Tests