test(openshell): clarify manifest allowlist wording

[apurvvkumaria]

Summary

Clarify the OpenShell v0.0.99 installer-hash regression title by describing the manifests as allowlisted. This is the semantic wording follow-up identified after #8499 merged; test behavior is unchanged.

Related Issue

Follow-up to #8499.

Changes

• Replace process-oriented reviewed wording with the precise allowlisted state in the v0.0.99 installer-hash test title.
• Keep the existing local reference in the final suffix position accepted by the repository test-title gate.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification: this is a test-title-only semantic correction; the focused installer-hash file passed all 77 cases and the title-style gate passed.
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: the change does not alter public behavior, configuration, commands, defaults, or documentation claims.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: only test/installer-hash-check.test.ts title terminology changes; public behavior, configuration, commands, defaults, and documentation claims are unchanged.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project integration test/installer-hash-check.test.ts passed 77 tests; npm run test:titles:check passed.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Apurv Kumaria akumaria@nvidia.com

Summary by CodeRabbit

• Tests
  • Updated release test wording to clarify that the manifests are allowlisted.

[coderabbitai]

📝 Walkthrough

Walkthrough

The OpenShell 0.0.99 installer hash test description now identifies the manifests as allowlisted. Test behavior and assertions remain unchanged.

Changes

Installer hash test

Layer / File(s)	Summary
Update manifest terminology test/installer-hash-check.test.ts	The test description changes from “reviewed” manifests to “allowlisted” manifests. Test behavior and assertions remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• NVIDIA/NemoClaw#8499: Adds and tests the v0.0.99 manifest allowlist referenced by this test description.

Suggested reviewers: cv, senthilr-nv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the terminology clarification in the OpenShell installer-hash test.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/8499-allowlisted-manifest-wording

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 392c9bb in the codex/8499-allowlist... branch remains at 96%, unchanged from commit cc4b816 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 392c9bb in the codex/8499-allowlist... branch remains at 81%, unchanged from commit bfc2baf in the main branch.

Show a code coverage summary of the most impacted files.

File	main bfc2baf	codex/8499-allowlist... 392c9bb	+/-
src/lib/onboard...carryforward.ts	96%	88%	-8%
src/lib/platform.ts	89%	84%	-5%
src/lib/onboard...oute-handoff.ts	95%	92%	-3%
src/lib/onboard...-transaction.ts	93%	93%	0%
src/lib/inferen...ompatibility.ts	90%	90%	0%
src/lib/messagi...nnels/policy.ts	100%	100%	0%
src/lib/onboard/temp-files.ts	100%	100%	0%
src/lib/sandbox...rce-identity.ts	83%	83%	0%
src/lib/tunnel/services.ts	80%	80%	0%

---

_{Updated August 07, 2026 07:52 UTC}

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Failed

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

1 semantic terminology decision

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• established — allowlisted at test/installer-hash-check.test.ts:999: Keep “allowlisted”; it identifies the authorization mechanism that the test verifies.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite against this exact revision.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

[cv]

Please refresh this branch onto the current main commit and rerun the required checks. The current base SHA is c11f4555, while main is bfc2bafd; repository policy does not permit approval of a stale branch. I found no code or test-title defect in the one-line change.

[apurvvkumaria]

Addressed the requested refresh by merging current main (bfc2bafd) into this PR branch. The effective change remains the single test-title wording update from reviewed to allowlisted; the merge was conflict-free and introduced no resolution edits.

Validation on the refreshed branch:

• test/installer-hash-check.test.ts: 77 passing
• test-title style gate: passing
• documentation writer review: no documentation changes needed; receipt refreshed
• security review: no findings because runtime behavior, assertions, credentials, policy, and configuration are unchanged

Fresh required checks are now running.