Skip to content

feat(installer): add Spark express vLLM profile option - #8512

Draft
ericksoa wants to merge 12 commits into
mainfrom
feat/spark-express-vllm-e2e
Draft

feat(installer): add Spark express vLLM profile option#8512
ericksoa wants to merge 12 commits into
mainfrom
feat/spark-express-vllm-e2e

Conversation

@ericksoa

@ericksoa ericksoa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a second DGX Spark Express inference option for the fixed catalog-backed vLLM profile and a physical end-to-end qualification target.

Type of Change

  • Code change with doc updates

Quality Gates

  • Tests added or updated for changed behavior
  • Docs updated for user-facing behavior changes
  • Sensitive paths changed (onboarding and inference)
  • Sensitive-path review completed or maintainer-approved waiver recorded

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: docs-updated
  • Evidence: docs/get-started/prerequisites.mdx, docs/inference/choose-local-inference-server.mdx, docs/inference/set-up-vllm-on-two-dgx-sparks.mdx, docs/inference/set-up-vllm.mdx, docs/reference/platform-support.mdx, docs/resources/prompt-assets/dgx-spark.md, docs/resources/starter-prompt.md, and test/e2e/README.md; reviewed the exact final branch patch, code, tests, and mock-parity registration at 26e901ae9.
  • Agent: Codex Desktop

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • npm run validate:pr
  • Targeted tests: 111 passed, 1 skipped
  • E2E semantic phase coverage: 123 tests across 80 files
  • npm run docs
  • Documentation follows the style guide
  • New documentation pages: not applicable

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@ericksoa ericksoa self-assigned this Aug 7, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9ec23b31-0f76-494c-831e-f2d1091953fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@github-code-quality

github-code-quality Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit d1e76fe in the feat/spark-express-v... branch remains at 96%, unchanged from commit c11f455 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit d1e76fe in the feat/spark-express-v... branch remains at 81%, unchanged from commit 312f8d1 in the main branch.


Updated August 07, 2026 04:03 UTC

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / low confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: Partial review preserved 0 canonical finding(s) and 3 terminology decision(s) before the advisor stopped.

Model lanes

  • GPT-5.6 Terra (primary): Failed after a partial review · low confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

3 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

  • established — DGX Spark Express at docs/inference/choose-local-inference-server.mdx:26: Keep `DGX Spark Express` for the interactive Spark installation flow.
  • justified — automatic serving-profile selection at docs/resources/prompt-assets/dgx-spark.md:13: Keep the term for option 1 and retain its contrast with the fixed profile.
  • justified — fixed catalog-backed vLLM profile at docs/resources/prompt-assets/dgx-spark.md:14: Keep the term for option 2 and state that catalog-owned settings reject overrides where relevant.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite against this exact revision.

Recommended E2E: cloud-inference, cloud-onboard, managed-image-multiarch-startup, security-posture

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@cv cv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product scope and security review are incomplete. This draft adds a second DGX Spark Express option, fixed vLLM profile, installer behavior, public documentation, and a physical qualification target without a linked accepted issue or design decision. Record the decision that defines ownership, lifecycle, compatibility, security, and hardware validation for this supported surface, and complete the required sensitive-path review and exact DGX Spark evidence before marking the PR ready. Refresh onto current main and rerun all required checks afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants