feat(installer): add Spark express vLLM profile option - #8512
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-8512.docs.buildwithfern.com/nemoclaw |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit d1e76fe in the TypeScript / code-coverage/cliThe overall coverage in commit d1e76fe in the Updated |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
PR Review Advisor — InformationalAdvisor assessment: Informational / low confidence Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
cv
left a comment
There was a problem hiding this comment.
Product scope and security review are incomplete. This draft adds a second DGX Spark Express option, fixed vLLM profile, installer behavior, public documentation, and a physical qualification target without a linked accepted issue or design decision. Record the decision that defines ownership, lifecycle, compatibility, security, and hardware validation for this supported surface, and complete the required sensitive-path review and exact DGX Spark evidence before marking the PR ready. Refresh onto current main and rerun all required checks afterward.
Summary
Adds a second DGX Spark Express inference option for the fixed catalog-backed vLLM profile and a physical end-to-end qualification target.
Type of Change
Quality Gates
Documentation Writer Review
docs-updateddocs/get-started/prerequisites.mdx,docs/inference/choose-local-inference-server.mdx,docs/inference/set-up-vllm-on-two-dgx-sparks.mdx,docs/inference/set-up-vllm.mdx,docs/reference/platform-support.mdx,docs/resources/prompt-assets/dgx-spark.md,docs/resources/starter-prompt.md, andtest/e2e/README.md; reviewed the exact final branch patch, code, tests, and mock-parity registration at26e901ae9.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubnpm run validate:prnpm run docsSigned-off-by: Aaron Erickson aerickson@nvidia.com