feat(skills): add issue implementation workflow - #8417
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a generic contributor skill for implementing accepted issues. It defines routing, local-only changes, repository discovery, focused validation, security self-review, structured handoff reporting, catalog registration, evaluation cases, and frontmatter tests. ChangesIssue implementation workflow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Contributor
participant IssueImplementationSkill
participant LocalCheckout
participant Validation
participant Handoff
Contributor->>IssueImplementationSkill: request accepted issue implementation
IssueImplementationSkill->>LocalCheckout: inspect context and apply scoped changes
LocalCheckout->>Validation: run focused tests and security checks
Validation-->>Handoff: provide recorded evidence
Handoff-->>Contributor: report changes, gates, and GitHub-write status
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit f7a82d1 in the TypeScript / code-coverage/cliThe overall coverage in commit f7a82d1 in the Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/skills-frontmatter.test.ts (1)
192-224: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftSeparate artifact contracts from routing evaluation.
test/skills-frontmatter.test.tsonly readsSKILL.mdandevals.json; it does not execute prompts or routing. Remove the exact evaluation-order assertion, keep only required safety and metadata contracts, and run prompt cases in the routing evaluator keyed byid.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/skills-frontmatter.test.ts` around lines 192 - 224, Update the test around the SKILL.md metadata assertions to remove the exact evals.map(({ id }) ordering assertion. Keep assertions limited to required safety and artifact contracts, and move prompt-case execution and routing validation into the routing evaluator, keyed by each eval’s id.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/skills-frontmatter.test.ts`:
- Around line 192-224: Update the test around the SKILL.md metadata assertions
to remove the exact evals.map(({ id }) ordering assertion. Keep assertions
limited to required safety and artifact contracts, and move prompt-case
execution and routing validation into the routing evaluator, keyed by each
eval’s id.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d7c910d0-176b-4700-afd1-c3a1db78557c
📒 Files selected for processing (5)
.agents/skills/nemoclaw-contributor-implement-issue/SKILL.md.agents/skills/nemoclaw-contributor-implement-issue/agents/openai.yaml.agents/skills/nemoclaw-contributor-implement-issue/evals/evals.json.agents/skills/nemoclaw-skills-guide/SKILL.mdtest/skills-frontmatter.test.ts
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
1 participant
Summary
Add a generic contributor workflow for implementing accepted issues from current repository evidence. The workflow delivers one independently valuable capability slice, records focused validation and security evidence, and routes publication to the separate PR workflow.
This PR is stacked on PR #8396.
Related Issue
Fixes #8363
Changes
nemoclaw-contributor-implement-issuewith explicit implementation, planning, publication, security-review, and maintainer routing boundaries.Type of Change
Quality Gates
docs/.Documentation Writer Review
no-docs-neededdocs/change is required.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablevitest run --project integration test/skills-frontmatter.test.ts— 34 tests passed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit
New Features
Documentation
Tests