Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Authoring session — openingAuthoring cutoff: 2026-11-12 20:20:41 UTC. Scope: this test implementation through commit
Local validation at opening:
The mandatory merge gate in the PR description remains outstanding. Testing Fabric's open PR head will not replace qualification after Fabric merges and V1 updates its pin. |
Local validation — Fabric PR #627 headBoth requested test extensions passed on Linux ARM64 with a temporary, unpublished override of Fabric PR #627. This does not satisfy the merge gate: keep this PR draft and unmerged until #627 lands, V1's pin includes it, and this PR is requalified against that V1 pin. Test commit: The disposable validation tree changed the Fabric source archive/checksum, regenerated its adapter catalog, and updated all three Rust Observed results:
Artifact SHA-256 identities:
|
…ry-tests Signed-off-by: Carlos Villela <cvillela@nvidia.com> # Conflicts: # crates/nemoclaw-e2e/tests/e2e/hcl_live.rs # crates/nemoclaw-e2e/tests/integration/rust/deployment.rs
- The case's fixture writes its request counts to the run's reports, so the docker-dummy run that sends the requests asserts on them directly; the middleware module and its observation probe go. - One sandbox command sends the three requests. - Drop the unchanged reapply and sandbox identity check: the case's unchanged plan already shows no changes. - Bind the middleware ports and addresses inside dummy_case, before the UID and digest. - The export journey's middleware policy keeps only the fields the binding needs. - Document the middleware checks in the live test guide. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
/ok to test b033521 |
The dummy case binding ran docker network inspect, so its unit test failed on hosts without Docker, such as the macOS runner. prepare reads the address and passes it in, and the test checks that the binding selects both recorder addresses. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Extend NemoClaw's tests to observe middleware request effects in the
docker-dummylive lifecycle and to keep an authored middleware binding through bundled CLI export and SDK reapply.Problem
Existing middleware tests check configuration projection and document compilation. They do not observe middleware interception and destination effects in the live Docker lifecycle. The bundled CLI export/reapply journey has no authored middleware binding.
Change
docker-dummy's gateway registers an external gRPC middleware thathcl_live::caseserves on the host, beside an HTTP effect recorder; both write the requests they see tomiddleware-effects.jsonin the run's reports. One sandbox command sends three requests, and the same run block asserts on the counts:cargo ci live-dockerbinds the middleware and recorder ports and the two addresses to each run.Beyond CI
cargo ci live-dockerpassed on linux/arm64 against v1's Fabric pin,b4725580(NVIDIA/NeMo-Fabric#632's head, which includes NVIDIA/NeMo-Fabric#627). With the destination expectation deliberately changed to include/deny, themiddlewarerun block failed and reported{"destination":{"/allow":1,"/bypass":1},"middleware":{"/allow":1,"/deny":1}}.