Repository navigation
chore(fabric): pin Fabric with the skill-path review fixes - #14301
Merged
Merged
Conversation
Move the Fabric pin to 7f362e09, the reviewed head of NVIDIA/NeMo-Fabric#615. The OpenClaw and Hermes adapters now ignore folders they can't read inside a folder of skills, such as a volume's lost+found, and fail start on an entry they can't read. With runtime.keep_state, the kept-state folder is owner-only, and agent names and adapter IDs that can't be folder names on Windows are refused. Skills on a Mounted Volume lists how Hermes and OpenClaw differ from Fabric's rule when they load the resolved skills. The integration fixtures follow the new catalog's fixture image digest. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Collaborator
Author
Authoring session — opening
|
cv
enabled auto-merge (squash)
November 7, 2026 13:52
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14301.docs.buildwithfern.com/nemoclaw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Fabric pin to 7f362e09, the reviewed head of NVIDIA/NeMo-Fabric#615, so OpenClaw and Hermes agents report a skill path they can't read by name, and documents where Hermes and OpenClaw load skills differently from Fabric's rule.
Problem
At the current pin (ec77dcc0), when a
skillspath or a skill'sSKILL.mdcan't be read, the OpenClaw and Hermes adapters stop at start with an unhandledPermissionErrorinstead of an error naming the path. The agent images run the adapters on Python 3.14, which already skips an unreadable folder inside a folder of skills, such as a new volume'slost+found. Fabric now skips it on every Python version, and Skills on a Mounted Volume says so.The page also doesn't say that Hermes loads skills nested inside a skill folder, that it refuses a skill named like another skill's folder, or that Fabric's duplicate check sees only the skills it resolves.
Change
image/fabric/Dockerfileand every copy: Cargo manifests andCargo.lock, the bundled catalog, and the pinned links in the docs. The catalog, regenerated from a freshly built image, changes only its revision and checksum; the descriptors are unchanged.runtime.keep_state, the kept-state folder is owner-only (0700);.archive, which Fabric loads as skills;~and${VAR}, which Fabric doesn't expand.The Fabric rule stays as it is; the table documents each harness's behavior rather than adding checks for it.
Beyond CI
IMAGE_PREFIX=nc-contract cargo images build --platform linux/arm64 agents dummy, then passedcargo images qualifyon all 12.image/fabric/catalog.jsonwithimage/fabric/catalog.pyfrom the built OpenClaw image's/opt/fabric/bin/python; it matched the committed file byte for byte.