Skip to content

chore(fabric): pin Fabric with the skill-path review fixes - #14301

Merged
cv merged 1 commit into
v1from
chore/fabric-pin-skills-review
Nov 7, 2026
Merged

cv merged 1 commit into
v1from
chore/fabric-pin-skills-review

Conversation

@cv

@cv cv commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Moves the Fabric pin to 7f362e09, the reviewed head of NVIDIA/NeMo-Fabric#615, so OpenClaw and Hermes agents report a skill path they can't read by name, and documents where Hermes and OpenClaw load skills differently from Fabric's rule.

Problem

At the current pin (ec77dcc0), when a skills path or a skill's SKILL.md can't be read, the OpenClaw and Hermes adapters stop at start with an unhandled PermissionError instead of an error naming the path. The agent images run the adapters on Python 3.14, which already skips an unreadable folder inside a folder of skills, such as a new volume's lost+found. Fabric now skips it on every Python version, and Skills on a Mounted Volume says so.

The page also doesn't say that Hermes loads skills nested inside a skill folder, that it refuses a skill named like another skill's folder, or that Fabric's duplicate check sees only the skills it resolves.

Change

  • Pin Fabric at 7f362e09 in image/fabric/Dockerfile and every copy: Cargo manifests and Cargo.lock, the bundled catalog, and the pinned links in the docs. The catalog, regenerated from a freshly built image, changes only its revision and checksum; the descriptors are unchanged.
  • The new pin also includes the review fixes from feat: keep an agent's state in one folder across its runtimes NeMo-Fabric#572:
    • with runtime.keep_state, the kept-state folder is owner-only (0700);
    • agent names and adapter IDs that can't be folder names on Windows are refused;
    • a workspace patch leaves out kept state by literal path.
  • Skills on a Mounted Volume now says that unreadable folders are ignored and that an unreadable path fails. Its new table covers:
    • nested skills, which Hermes loads;
    • the scope of Fabric's duplicate check;
    • Hermes's lookup by name, folder name, and path;
    • Hermes's 64-character name limit;
    • hidden folders such as .archive, which Fabric loads as skills;
    • ~ and ${VAR}, which Fabric doesn't expand.
  • The integration fixtures follow the new catalog's fixture image digest and the inference resource names derived from it.

The Fabric rule stays as it is; the table documents each harness's behavior rather than adding checks for it.

Beyond CI

  • Built every agent image and the dummy image on linux/arm64 with IMAGE_PREFIX=nc-contract cargo images build --platform linux/arm64 agents dummy, then passed cargo images qualify on all 12.
  • Regenerated image/fabric/catalog.json with image/fabric/catalog.py from the built OpenClaw image's /opt/fabric/bin/python; it matched the committed file byte for byte.

Move the Fabric pin to 7f362e09, the reviewed head of NVIDIA/NeMo-Fabric#615.
The OpenClaw and Hermes adapters now ignore folders they can't read inside a
folder of skills, such as a volume's lost+found, and fail start on an entry
they can't read. With runtime.keep_state, the kept-state folder is
owner-only, and agent names and adapter IDs that can't be folder names on
Windows are refused.

Skills on a Mounted Volume lists how Hermes and OpenClaw differ from
Fabric's rule when they load the resolved skills. The integration fixtures
follow the new catalog's fixture image digest.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv

cv commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Pi 1.5.0 Session record format and the harness's documentation path for release 1.5.0
Skills recorded review-doc-style (complete read); nemoclaw-contributor-create-pr (complete read); python-tests (partial read); prepare-pr (partial read) Skill reads in the session record to the cutoff; one helper session also did the NeMo Fabric work this pin picks up
Instruction files recorded NeMo Fabric AGENTS.md (injected); NemoClaw AGENTS.md (complete read); WRITING.md (complete read); internal-docs/contributing/agent-image-maintenance.md (complete read); .github/PULL_REQUEST_TEMPLATE.md (complete read); .github/SESSION_REPORT_TEMPLATE.md (complete read); NeMo Fabric CONTRIBUTING.md (partial read) Startup injection and reads in the session record to the cutoff
Tool calls partial typescript: 341 Includes 7 failed calls; the typescript wrapper runs shell, git, and gh calls that the record does not count separately
Session window recorded 2026-11-07T02:56Z to 2026-11-07T13:53Z; 10 h 57 min First event to the cutoff, including idle time; the NemoClaw change started at about 13:10Z, after the NeMo Fabric work in the same session
Compactions recorded 0 Complete record to the cutoff; 12 context edits summarized finished turns without compaction
Models recorded nvidia-internal/aws/anthropic/bedrock-claude-opus-5-5 Model change event at session start; no later changes
Reasoning levels recorded high Thinking-level event at session start; no later changes

@cv
cv enabled auto-merge (squash) November 7, 2026 13:52
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@cv
cv merged commit ab8d536 into v1 Nov 7, 2026
68 checks passed
@cv
cv deleted the chore/fabric-pin-skills-review branch November 7, 2026 14:11
@wscurran wscurran added area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery area: security Security controls, permissions, secrets, or hardening area: skills Skills, agent behaviors, prompts, or skill packaging chore Build, CI, dependency, or tooling maintenance integration: hermes Hermes integration behavior integration: openclaw OpenClaw integration behavior v1 NemoClaw v1 branch labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery area: security Security controls, permissions, secrets, or hardening area: skills Skills, agent behaviors, prompts, or skill packaging chore Build, CI, dependency, or tooling maintenance integration: hermes Hermes integration behavior integration: openclaw OpenClaw integration behavior v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants