Repository navigation
feat(fabric)!: accept a skill folder or a folder of skills in skills.paths - #14296
Merged
Merged
Conversation
…paths Pin Fabric ec77dcc0, the head of NVIDIA/NeMo-Fabric#615, so OpenClaw and Hermes resolve each skills.paths entry as one skill (it contains SKILL.md) or a folder of skills (each folder directly inside it that contains SKILL.md). A folder without skills adds none; a missing path or a duplicate skill name stops the agent from starting. The interfaces live case mounts a folder of skills and a separate skill for each agent, and Skills on a Mounted Volume shows both forms mixed. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…abric-boundary Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Collaborator
Author
Authoring session — opening
|
cv
enabled auto-merge (squash)
November 7, 2026 01:40
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14296.docs.buildwithfern.com/nemoclaw |
cv
added a commit
that referenced
this pull request
Nov 11, 2026
…ms (#14413) The release notes now list every user-visible change on `v1` since the `v0.1.0-rc9` tag, including the breaking ones, and four example pages drop claims that later changes made false. ## Problem `docs/about/release-notes.md` listed three breaking changes and none of the features, fixes, and onboarding changes that reached `v1` after `v0.1.0-rc9`; it didn't name the configuration shapes the parser now rejects or the intent record version `v0.1.0-rc9` writes. Some example claims went stale: - `examples/spark/README.md` said the pinned OpenShell has the Podman TLS initialization blocker, NVIDIA/OpenShell#3427; its fix merged before OpenShell 0.1.0, and `v1` pins 0.1.7. - `examples/station/README.md` and `examples/gtc-dc/README.md` required exactly one visible GPU on the host; since #13929, `container.gpuDevices` lets a service on a host with more GPUs request one. - `examples/hcl/travel-team` said Fabric's Deep Agents adapter can't turn reasoning off, NVIDIA/NeMo-Fabric#433; NVIDIA/NeMo-Fabric#439 fixed that, and the pinned catalog's Deep Agents `reasoning_effort` accepts `none`. - The travel team cited #13313 for the booking key its service doesn't receive, but #13313 closed when `openshell_api` landed. ## Change - `docs/about/release-notes.md` gains "Changes Since v0.1.0-rc9", grouped by area, from the commits in `v0.1.0-rc9..origin/v1`; where a later commit changed an earlier one, the entry describes the current code, and changes added and removed after the tag aren't listed: - Agents and interfaces: #14037, #14038, #14269, #13981, #14024, #14186, #14052, #14385, #13971, #13858, #13947, #14039, #14042, #14044, #14343. - Inference: #13929, #14391, #14396, #14398, #14400, #13963, #13912, #13964, #14388, #14390, #14397. - Gateways and Kubernetes: #13909, #13970, #13922 (an existing namespace, refused at plan by #13756, is now bound; cluster-wide reads dropped), #14014, #14169, #13921. - Plan, apply, and diagnostics: #14224, #13756, #14141, #14133, #14135, #13775, #13744, #13701. - Onboarding: #13693, #13695, #13741, #13757, #13851, #13978, #14228, #14233, #14334, #14336. - Examples and builds: #14166, #14184, #14188, #14191, #14192, #14200, #13889, #14267, #14312, #14315, #14355, b30e9b4, #13781, #13813, #14246, and the pins in `versions.json` and `image/fabric/Dockerfile`. - Its breaking changes since the tag: - the intent record moving from 15, which `v0.1.0-rc9` writes, through 16 (#14266), 17 (#14343), 18 (#13929), 19 (#14391) and 20 (#14394); - name-keyed `sandboxes` and `inferenceProviders` (#13703, #13705); - a recipe `compatibility.gpu` outside every hardware profile (#13912); - model tuning the adapter doesn't accept (#14111), and Hermes's `max_tokens` losing its default (#14296); - `skills.paths` resolution (#14296); - endpoint and `networkCIDR` validation (#13847, #14081); - the HCL `gateway_values` attribute (#14014), and Kubernetes ownership receipts from before #13922 and #14014. The two earlier items stay, under their own heading. - `examples/spark/README.md` replaces the closed OpenShell#3427 blocker with the Podman and remote-model limits in `docs/resources/limits.md`. - `examples/station/README.md` and `examples/gtc-dc/README.md` require one GPU visible in the model container, and point to `container.gpuDevices` for a host with more. - `examples/hcl/travel-team/README.md` and `WALKTHROUGH.md` drop the NeMo-Fabric#433 limitation, and the travel team's booking-key statements link #14417 instead of #13313. Not listed, because both changes landed after the tag: Deep Agents Code (#14043, #14250), `compatibility.gpuCount` (#14391, #14394), and the "Creating infrastructure state" progress step (#14169, #14248). Checked and left unchanged: the root `README.md`, `crates/nemoclaw-onboarding/README.md`, `crates/nemoclaw-cli/assets/README.md`, `internal-docs/README.md`, the other example READMEs, and every example YAML header comment. The GPU autoscaling README and `load.sh` read the JSON fields `OperationResult` serializes, and NVIDIA/OpenShell#4287 is fixed only after the pinned 0.1.7. The two pre-tag release-note items still match the schema and SDK. `docs/README.md` is left to #14412, which retires the stale field reference snapshot it describes. Not verified: whether Hermes sends the booking key's placeholder to MCP servers; #14417 tracks the live check. ## Beyond CI Each relative link and anchor in the changed files resolves to an existing file and heading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenClaw and Hermes agents can now list both kinds of folder in
skills.paths: a folder that is one skill, and a folder of skills. A deployment can mix them, for example a shared volume of team skills plus one skill mounted on its own with its own mount settings. NemoClaw pins a Fabric revision that applies this rule.Problem
Skills on a Mounted Volume mounts a volume on
/sandbox/skillsand lists that path for an OpenClaw agent. At Fabric934ab7ec, OpenClaw accepted a path only if it containedSKILL.mditself. With a new, empty volume or a volume holding a folder per skill, the agent failed to start (start_failed, causeopenclaw_skill_invalid). Hermes searched every listed folder recursively, at any depth, and skipped a missing path without an error. #14271 left the OpenClaw side open.Change
The Fabric pin moves to
ec77dcc0132bb02198f7aac736671bd0effa87eb, the head of NVIDIA/NeMo-Fabric#615, which is stacked on NVIDIA/NeMo-Fabric#576. It is kept reachable as branchintegration/nemoclaw-pin-skillsoncv/NeMo-Fabric. The pin now equals the Fabric stack's top pull request exactly, with no extra merges or reverts. NVIDIA/NeMo-Fabric#615's base already contains Fabricmain, NVIDIA/NeMo-Fabric#573, NVIDIA/NeMo-Fabric#572 and NVIDIA/NeMo-Fabric#576.For OpenClaw and Hermes, each
skills.pathsentry is now resolved like this:SKILL.mdis one skill;SKILL.mdis a skill, and other files and folders are ignored;What Hermes users lose: skills more than one folder deep inside a listed folder no longer load. A listed path that doesn't exist now stops the agent from starting.
Other Fabric changes between the two pins:
max_tokenssetting no longer has a default of 512. This is the only descriptor change in the regeneratedimage/fabric/catalog.json, apart from the revision and checksum.main._port_availableinstead of importingport_availablefrom Fabric's common adapter package.In this repository:
FABRIC_REVISIONandFABRIC_SHA256inimage/fabric/Dockerfile, thenemo-fabric-corerevisions in the three crates andCargo.lock, the regenerated catalog, and the pinned links in the docs. The Hermes bundled-plugin recipe keeps934ab7ec, because it records the binding the recipe was written against.Skills on a Mounted Volume states the rule and shows two agents. An OpenClaw agent and a Hermes agent share a read-only
team-skillsvolume that holds a folder per skill, and only the OpenClaw agent also mounts a writablereview-skillvolume that is one skill. The page has YAML and HCL versions of the example.The
docker-openclaw-hermes-interfaceslive case gives each sandbox two skills volumes and lists both mounts inskills.paths:The
tests/e2e/hcl/volumemodule takes an optionalfilesmap and writes those files before the agent starts.cargo ci live-dockernames the volumes after the run's UID. Whether an agent uses a skill isn't checked live: Fabric's tests check what each harness loads.The verify-fabric-boundary skill no longer says OpenClaw needs each path to be one skill folder. It still lists the supplied skill's own folder.
The fixture image that the HCL cases name, and the registration names in
openshift-external-two-providers, follow the new catalog.Beyond CI
start_failed, causeopenclaw_skill_invalid. After it, the case passed.linux_arm64:cargo images buildbuilt all 11 production agent images and the reference image, andcargo images qualifypassed for all 12;catalog.py, run with the built Claude Code image's interpreter, produced the committed catalog.codeloadarchives ofec77dcc0underNVIDIA/NeMo-Fabricandcv/NeMo-Fabrichave the pinned SHA-256.ec77dcc0's tests are reported in feat: accept a skill folder or a folder of skills in skills.paths NeMo-Fabric#615.Not run:
cargo ci live-kind, and the images onlinux/amd64. The Kubernetes images change only by the Fabric pin.