Repository navigation
fix(skills): drive verify-yaml-deployment without host Python or Node - #14196
Merged
Merged
Conversation
Drive dcode's terminal UI with shell functions around util-linux script, replace the PyYAML snippets with hand edits and checks, and run the dashboard's Playwright driver inside its pinned image. Proven live on DGX Spark for deepagents-code, openclaw, and hermes.
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14196.docs.buildwithfern.com/nemoclaw |
Check for an interrupted answer after Ctrl-D, stop typing into an ended session, check once more after a wait ends, and strip more control sequences. Add the probe exposure to an existing map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
verify-yaml-deploymentran Python and Node on the host, whichAGENTS.mdrules out (#14182):features/deepagents-code-terminal.mdwrote and ran a 47-lineterminal.pyto drivedcode.agents/deepagents-code.md,features/exposure-change.md, andtargets/dgx-spark.mdedited the YAML withpython3and PyYAML, which also dropped the example's comments.features/openclaw-dashboard.mdinstalled an unpinnedplaywrightfrom npm on the host and ran it with Node.Decision
scriptreplaceterminal.py. They type into a FIFO and read the screen fromscript's output file, using the same mechanism aspseudo_terminal.rsin theinterfaces_livetest. They keep the steps, the pass lines (ui ok,reply ok,exit 0), and the evidence files.sedandgreprun underLC_ALL=C: inen_US.UTF-8, the range[@-~]misses letters such asK, which leaves control sequences in the text.After review, the driver checks for
Interrupted by userafter Ctrl-D, when the UI reports it. It stops typing once the session has ended, so a launcher that exits at once can't kill the shell with SIGPIPE. It checks once more after a wait ends. It also strips DCS, APC, and colon-form SGR sequences, and turns carriage returns into line breaks.SKILL.mdalready allowed them, and they are what a configuration author does. Each edit shows the target YAML and agrepcheck, and the launch savesyaml-edits.diffagainst the example. A Rust helper would duplicate authoring for three small edits.mcr.microsoft.com/playwrightv1.64.1, pinned by digest, on the host network so the origin stays loopback. The token goes in the container's environment, not its arguments. Driving the WebSocket instead would drop the only proof of browser sign-in and the loopback-origin check (feat: share OpenClaw configuration across native interfaces NeMo-Fabric#573). A Rust CDP or WebDriver driver would add a dependency and a host Chromium for one skill.Whether
create-verification-skill/SKILL.md's Helpers rule should name this exception is left to review; this PR changes only the verify skill.verify-fabric-boundary/features/native-interfaces.mdreuses both drivers. Its references stay accurate, but this PR doesn't rerun that skill.Validation
The changed procedures ran live on the DGX Spark target at
b5489e5768plus this change, on 2026-11-04. Every command came from the edited files, extracted from their code blocks. Each agent got a full pass with its own UID, gateway port and subnet, against an existing vLLM endpoint servingnemotron-3.5-super-vl:deepagents-code: DT1–DT4 passed through the new terminal driver.dcodeanswered the prompt on its own line, withopenai:nemotron-3.5-super-vlin the status line and exit status0. After the replacement, the old launcher reportedNo such file or directoryand the new one passed again.openclaw: DB1–DB5 passed. DB5 printedreplyfrom Chromium inside the pinned image, and its screenshot shows the signed-in Control UI with the prompt and the agent's reply. exposure-change ran itsSTRIPbranch.hermes: HI1–HI4 passed. exposure-change ran itsprobebranch.READY_OK, andCHANGED_OKunder the replacement runtime.python3,python,node,npm, andnpxcommands that log any call were first onPATHfor every run, and none was called.reply okfor an interrupted answer. Its shell also died with status 141 when the launcher exited at once, or exited right after answering. The fixed driver reportedreply FAIL,ui FAILwithexit 1, andreply ok, and left no escape bytes in any transcript. A second livedeepagents-codepass then ran, using the fixed files, with a new UID, port, and subnet. It covered DA1, DT1–DT4, export-reapply, and exposure-change; both terminal sessions printedui ok,reply ok,exit 0. Their transcripts hold the word on its own line andopenai:nemotron-3.5-super-vl, with noInterrupted by user. That pass reused the first pass's hand-edited YAML, changing only its identity, gateway port, subnet, and image. Destroy and removal again left no resources, and no host Python or Node ran.The documentation check (
fern check) coversdocs/, not skills, so the local checks were a reread of the diff andgit diff --check. No code changed, so I didn't runcargo ci.